Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces support for building and packaging the
txdbinary for both Alpine (musl/static) and Debian/Ubuntu (glibc/dynamic) Docker images. It enables flexible selection of the base image and linking strategy via a new--override-txd-osflag or environment variable. The changes also streamline dependency management, update relevant toolchain logic, and ensure the correct handling of the WASM VM library for each platform.Build system enhancements (Docker, linking, and platform support):
txdwith a dynamically linkedlibwasmvmshared library for Debian/Ubuntu images, while retaining static linking for Alpine images. This includes new toolchain configuration, environment setup, and Dockerfile template changes to copy the.solibrary when needed. [1] [2] [3] [4] [5] [6] [7] [8]--override-txd-osCLI flag and$TXD_OSenvironment variable to select the base image and linking mode, with context propagation and default fallback.BuildTXdDockerImageand related functions to use the selected base image and linking mode, including proper handling of WASM library copying and toolchain setup. [1] [2]Dependency and toolchain updates:
libwasmvm-glibctool definition and download logic: Updatedbuild/tools/tools.goto define the new WASM VM shared library for glibc builds and added download URLs and hashes. [1] [2]build/go.mod, including new versions oftx-crust,tx-crust/znet, and IBC modules, and addedgithub.com/spf13/pflag. [1] [2] [3]General improvements and refactoring:
These changes collectively enable seamless builds and deployments of
txdfor both Alpine and Debian/Ubuntu environments, improving cross-platform compatibility and simplifying developer workflows.Reviewers checklist:
Authors checklist
This change is