Skip to content

Upgrade rust toolchain to 1.86#19

Closed
TxCorpi0x wants to merge 3 commits intomasterfrom
mehdi/update-rust-toolchain-1-82-0
Closed

Upgrade rust toolchain to 1.86#19
TxCorpi0x wants to merge 3 commits intomasterfrom
mehdi/update-rust-toolchain-1-82-0

Conversation

@TxCorpi0x
Copy link
Contributor

@TxCorpi0x TxCorpi0x commented Feb 19, 2026

Description

Set toolchain and minimum supported for this version according to wasmvm toolchain support

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@TxCorpi0x TxCorpi0x marked this pull request as ready for review February 23, 2026 06:00
@TxCorpi0x TxCorpi0x requested a review from a team as a code owner February 23, 2026 06:00
@TxCorpi0x TxCorpi0x requested review from masihyeganeh, metalarm10, miladz68 and ysv and removed request for a team February 23, 2026 06:00
masihyeganeh
masihyeganeh previously approved these changes Feb 23, 2026
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masihyeganeh reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on metalarm10, miladz68, and ysv).


build/tools/tools.go line 127 at r1 (raw file):

	// https://releases.rs
	RustInstaller{
		Version: "1.82.0",

Have you checked if our smart contracts work with Rust 1.82.0?
I remember we had an error related to the heap memory provided to them or something like that

@TxCorpi0x TxCorpi0x changed the title Upgrade rust toolchain to 1.82 Upgrade rust toolchain to 1.86 Feb 23, 2026
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on metalarm10, miladz68, and TxCorpi0x).


build/tools/tools.go line 127 at r1 (raw file):

Previously, masihyeganeh (Masih Yeganeh) wrote…

Have you checked if our smart contracts work with Rust 1.82.0?
I remember we had an error related to the heap memory provided to them or something like that

lets check it please

Copy link
Contributor Author

@TxCorpi0x TxCorpi0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on metalarm10, miladz68, and ysv).


build/tools/tools.go line 127 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

lets check it please

Generally, the rust toolchain, that should be used in the smart contract development, should be done with stable toolchain which is 1.93.1 at the moment, the wasmvm toolchain version is just constraints for the wasmvm build itself, but as we use the wasmvm binary, we are safe to use any stable version of toolchain to build the smart contract. i used 1.86.0, because it has been used in the recent rust optimizer of cosmwasm.
https://github.com/CosmWasm/cosmwasm?tab=readme-ov-file#developing

https://github.com/CosmWasm/optimizer/blob/main/CHANGELOG.md

This version is the only version that is compatible with cosmwasm v3+, so i thought it would be good to have update to this version so we would be compatible with the next version.

So we are safe to say we can use recent stable version, but i upgraded to v 1.86.0 as minimum requirement for the recent rust optimizer.

I have changed the rust toolchain everywere in the rust libs and contracts in bridge, so far i have not seen any failure from those usages, but i will update you when I am done with the recent tests.

Copy link
Contributor Author

@TxCorpi0x TxCorpi0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on metalarm10, miladz68, and ysv).


build/tools/tools.go line 127 at r1 (raw file):

Previously, TxCorpi0x wrote…

Generally, the rust toolchain, that should be used in the smart contract development, should be done with stable toolchain which is 1.93.1 at the moment, the wasmvm toolchain version is just constraints for the wasmvm build itself, but as we use the wasmvm binary, we are safe to use any stable version of toolchain to build the smart contract. i used 1.86.0, because it has been used in the recent rust optimizer of cosmwasm.
https://github.com/CosmWasm/cosmwasm?tab=readme-ov-file#developing

https://github.com/CosmWasm/optimizer/blob/main/CHANGELOG.md

This version is the only version that is compatible with cosmwasm v3+, so i thought it would be good to have update to this version so we would be compatible with the next version.

So we are safe to say we can use recent stable version, but i upgraded to v 1.86.0 as minimum requirement for the recent rust optimizer.

I have changed the rust toolchain everywere in the rust libs and contracts in bridge, so far i have not seen any failure from those usages, but i will update you when I am done with the recent tests.

During the call with the team, it was decided to stick into 1.81 as this version is the current toolchain version of the rust optimize v0.16

@TxCorpi0x
Copy link
Contributor Author

During the call with the team, it was decided to stick into 1.81.0 as this version is the current toolchain version of the rust optimize v0.16.1 so this PR will be closed

@TxCorpi0x TxCorpi0x closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants