Conversation
masihyeganeh
left a comment
There was a problem hiding this comment.
@masihyeganeh reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on metalarm10, miladz68, and ysv).
build/tools/tools.go line 127 at r1 (raw file):
// https://releases.rs RustInstaller{ Version: "1.82.0",
Have you checked if our smart contracts work with Rust 1.82.0?
I remember we had an error related to the heap memory provided to them or something like that
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on metalarm10, miladz68, and TxCorpi0x).
build/tools/tools.go line 127 at r1 (raw file):
Previously, masihyeganeh (Masih Yeganeh) wrote…
Have you checked if our smart contracts work with Rust 1.82.0?
I remember we had an error related to the heap memory provided to them or something like that
lets check it please
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on metalarm10, miladz68, and ysv).
build/tools/tools.go line 127 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
lets check it please
Generally, the rust toolchain, that should be used in the smart contract development, should be done with stable toolchain which is 1.93.1 at the moment, the wasmvm toolchain version is just constraints for the wasmvm build itself, but as we use the wasmvm binary, we are safe to use any stable version of toolchain to build the smart contract. i used 1.86.0, because it has been used in the recent rust optimizer of cosmwasm.
https://github.com/CosmWasm/cosmwasm?tab=readme-ov-file#developing
https://github.com/CosmWasm/optimizer/blob/main/CHANGELOG.md
This version is the only version that is compatible with cosmwasm v3+, so i thought it would be good to have update to this version so we would be compatible with the next version.
So we are safe to say we can use recent stable version, but i upgraded to v 1.86.0 as minimum requirement for the recent rust optimizer.
I have changed the rust toolchain everywere in the rust libs and contracts in bridge, so far i have not seen any failure from those usages, but i will update you when I am done with the recent tests.
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on metalarm10, miladz68, and ysv).
build/tools/tools.go line 127 at r1 (raw file):
Previously, TxCorpi0x wrote…
Generally, the rust toolchain, that should be used in the smart contract development, should be done with
stabletoolchain which is1.93.1at the moment, the wasmvm toolchain version is just constraints for the wasmvm build itself, but as we use the wasmvm binary, we are safe to use any stable version of toolchain to build the smart contract. i used1.86.0, because it has been used in the recent rust optimizer of cosmwasm.
https://github.com/CosmWasm/cosmwasm?tab=readme-ov-file#developinghttps://github.com/CosmWasm/optimizer/blob/main/CHANGELOG.md
This version is the only version that is compatible with cosmwasm v3+, so i thought it would be good to have update to this version so we would be compatible with the next version.
So we are safe to say we can use recent stable version, but i upgraded to v 1.86.0 as minimum requirement for the recent rust optimizer.
I have changed the rust toolchain everywere in the rust libs and contracts in bridge, so far i have not seen any failure from those usages, but i will update you when I am done with the recent tests.
During the call with the team, it was decided to stick into 1.81 as this version is the current toolchain version of the rust optimize v0.16
|
During the call with the team, it was decided to stick into |
Description
Set toolchain and minimum supported for this version according to wasmvm toolchain support
Reviewers checklist:
Authors checklist
This change is