Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces enhancements to the build system, focusing on extensible flag handling, improved Docker image OS management, and utility functions for flag resolution. The most important changes are grouped below:
Flag Handling and Extensibility
FlagRegistrartype and updated theMainfunction inbuild/build.goto allow callers to register custom flags and inject their values into the context before commands run. This enables more flexible and modular flag management for build commands. [1] [2]build/flags.gowith theResolveFlagfunction, providing a standardized way to resolve flag values with precedence: CLI flag > environment variable > default. This utility is intended for use with the new flag registration mechanism.Docker Image OS Management
build/docker/docker.goby introducing theImageOStype and methods. This replaces hardcoded image tags with a type-safe enum and a method to retrieve the full image reference, improving maintainability and clarity.Reviewers checklist:
Authors checklist
This change is