Skip to content

Destroy original digest auth request prior to making new one #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JordanDC2 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Destroy original digest auth request prior to making new one #442

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58c0320
Destroy original digest auth request prior to making new one
Jul 2, 2025
2744aed
fixed spacing
Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/needle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,10 @@ Needle.prototype.send_request = function(count, method, uri, config, post_data,

if (auth_header) {
config.headers['authorization'] = auth_header;
// Destroy the old request to prevent the unauthenticated digest request from causing the needle promise to catch/reject
// This is especially an issue with application/octet-stream request bodies where the server can cause the connection to reset
request.destroy();

return self.send_request(count, method, uri, config, post_data, out, callback);
}
}
Expand Down