Skip to content

Conversation

@iblue
Copy link

@iblue iblue commented Feb 13, 2019

This should improve the security of nsupdate-client in two ways:

  • Fetch IP address not via http (which is susceptible to MITM attacks)
  • Validate the fetched IP address, before including it in the update to prevent sending arbitrary updates in case the server at bot.whatismyipaddress.com git compromized.

There is still an exploitable race condition by using /tmp/$REC.tmp which can be exploited by creating this file first, but the attacker needs to be authenticated on the machine running nsupdate-client, so I can live with that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant