Update build by ash-sykes · Pull Request #40 · tomc128/noterly

ash-sykes · 2025-11-11T22:46:01Z

This is a bit of a WIP branch as I've not tested all functionality. Essentially it updates all the things: flutter version, gradle, android versions etc. As things are ~2 years out of date it's taken some significant effort to get it working again. One of the main differences is that the notification action buttons now work differently in order to dismiss an active notification (I've PoC'ed this change - but it was more a get it working than the ultimate end state solution).

- Use new version of recieve_share_intent that works with latest flutter - Switch to system_settings_2, a fork that works with latest flutter - Override intl version, to a version that works for latest flutter - Remove firebase

…tions

Not ideal to mash these together but lots of dart changes, mainly: - Remove firebase - Formatting changes - Add debugging support for notification actions - WIP fix for notification buttons

Copilot

Pull Request Overview

This PR updates the Flutter app's build infrastructure and dependencies, removing Firebase integration and upgrading Flutter, Gradle, and Android SDK versions. The changes include significant dependency version bumps and API migrations necessitated by ~2 years of framework evolution.

Key Changes:

Removed Firebase Analytics and Crashlytics integration
Updated Flutter dependencies including flutter_local_notifications (14.0.0 → 19.5.0), uuid (3.0.7 → 4.5.2), and others
Migrated Android build system to new Gradle plugin architecture
Updated API calls for deprecated Flutter/Material 3 components (ButtonBar → OverflowBar, DropdownButtonFormField.value → initialValue)
Modified notification action button handling for dismissal

Reviewed Changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
`pubspec.yaml`	Updated 15+ dependencies, removed Firebase packages, added git dependency for receive_sharing_intent
`pubspec.lock`	Resolved dependency versions with major version bumps across the board
`android/settings.gradle`	Migrated to modern Gradle plugin management with pluginManagement block
`android/gradle.properties`	Increased JVM heap size for builds
`android/build.gradle`	Removed buildscript block, updated to modern Gradle configuration
`android/app/build.gradle`	Updated to namespace-based configuration, Java 11, newer dependencies
`android/app/src/*/AndroidManifest.xml`	Removed package declarations, added notification broadcast receivers
`.tool-versions`	Added Flutter version specification
`lib/widgets/*.dart`	ButtonBar → OverflowBar, formatting changes for updated linter
`lib/pages/*.dart`	Removed Firebase calls, updated deprecated APIs (background → surface)
`lib/main.dart`	Removed Firebase initialization, updated sharing intent API
`lib/managers/notification_manager.dart`	Updated notification APIs, changed action button dismissal logic
`lib/firebase_options.dart`	Deleted (Firebase removed)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-15T14:19:41Z

noterly/android/app/build.gradle

@@ -82,10 +78,7 @@ android {
    }
    buildTypes {
        release {


[nitpick] The minifyEnabled setting has been removed from the release build type. The comment mentioned it was for "testing to try and fix splash screen hang issue". If this was solving a real issue, removing it might reintroduce that problem. If the issue is resolved by other changes, consider documenting why it's no longer needed.

Suggested change

release {

release {

// INFO: minifyEnabled was previously set for testing to try and fix splash screen hang issue.

// It has been removed because the splash screen hang issue was resolved by other changes (e.g., [specify changes if known]).

// If the issue reappears, consider re-adding minifyEnabled false.

Copilot · 2025-11-15T14:19:42Z

noterly/lib/widgets/repetition_picker.dart

+                          'time.year${_repetitionData.number == 1 ? '' : 's'}'))),
                ],
-                value: _repetitionData.type,
+                initialValue: _repetitionData.type,


The value property has been removed from DropdownButtonFormField in favor of initialValue. While this change has been made, ensure that the dropdown properly updates when the value changes through user interaction. The initialValue parameter only sets the initial state and won't update if _repetitionData.type changes elsewhere in the widget lifecycle.

Suggested change

initialValue: _repetitionData.type,

value: _repetitionData.type,

Copilot · 2025-11-15T14:19:42Z

noterly/lib/widgets/duration_picker.dart

+                          translate('time.minute${_value == 1 ? '' : 's'}'))),
                ],
-                value: _duration.inHours > 0 ? 'hour' : 'minute',
+                initialValue: _duration.inHours > 0 ? 'hour' : 'minute',


The value property has been removed from DropdownButtonFormField in favor of initialValue. While this change has been made, ensure that the dropdown properly updates when the value changes through user interaction. The initialValue parameter only sets the initial state and won't update if the duration type changes elsewhere in the widget lifecycle.

Copilot · 2025-11-15T14:19:42Z

noterly/lib/widgets/first_launch_dialog.dart

              DotsIndicator(
                dotsCount: pages.length,
-                position: currentPage,
+                position: currentPage.toDouble(),


The position parameter type for DotsIndicator has been changed to double (using .toDouble()), but currentPage is an int. This suggests an API change in the dots_indicator package. Verify that the indicator properly displays the current page position with this change.

Copilot · 2025-11-15T14:19:43Z

noterly/lib/managers/notification_manager.dart


      if (android != null) {
-        var result = await android.requestPermission();
+        var result = await android.requestNotificationsPermission();


The method signature has changed from requestPermission() to requestNotificationsPermission(). While this updates to the new API, ensure this method exists in the version of flutter_local_notifications being used (19.5.0). The API change appears correct for newer versions of the plugin.

Suggested change

var result = await android.requestNotificationsPermission();

var result = await android.requestPermission();

Copilot · 2025-11-15T14:19:44Z

noterly/lib/widgets/first_launch_dialog.dart

    required this.title,
    this.subtitle,
    required this.content,
-    this.image,
    this.child,


The image property has been removed from the _LaunchDialogPage constructor but not from the class definition. This creates an inconsistency - the property is still declared in the class but can't be initialized. Either remove the property declaration entirely or keep the constructor parameter.

Copilot · 2025-11-15T14:19:44Z

noterly/android/app/src/main/AndroidManifest.xml

+        <receiver android:exported="false" android:name="com.dexterous.flutterlocalnotifications.ActionBroadcastReceiver" />
+        <receiver android:exported="false" android:name="com.dexterous.flutterlocalnotifications.ScheduledNotificationReceiver" />
+        <receiver android:exported="false" android:name="com.dexterous.flutterlocalnotifications.ScheduledNotificationBootReceiver">
+            <intent-filter>
+                <action android:name="android.intent.action.BOOT_COMPLETED"/>
+                <action android:name="android.intent.action.MY_PACKAGE_REPLACED"/>
+                <action android:name="android.intent.action.QUICKBOOT_POWERON" />
+                <action android:name="com.htc.intent.action.QUICKBOOT_POWERON"/>
+            </intent-filter>
+        </receiver>


New broadcast receivers have been added for handling notification actions and boot events. Ensure these receivers are compatible with flutter_local_notifications v19.5.0. The package name com.dexterous.flutterlocalnotifications should match what the plugin expects - verify this matches the plugin's implementation.

Copilot · 2025-11-15T14:19:45Z

noterly/lib/managers/notification_manager.dart

+      Log.logger.e(
+          'Failed to show notification "${item.title}" at ${item.dateTime}',
+          error: e);


The change from Log.logger.e('...', e) to Log.logger.e('...', error: e) suggests a breaking change in the logger API. However, this is inconsistent - some calls use the named parameter pattern while the old pattern appears elsewhere (line 179). Ensure all error logging calls are updated consistently to use the new API.

Copilot · 2025-11-15T14:19:45Z

noterly/pubspec.yaml

+  receive_sharing_intent:
+    git:
+      url: https://github.com/KasemJaffer/receive_sharing_intent


[nitpick] The receive_sharing_intent dependency is now pointing to a Git repository instead of pub.dev. While this may be necessary for compatibility, consider:

This creates a dependency on GitHub availability

The specific commit (HEAD) is not pinned, which could lead to unexpected changes

Consider pinning to a specific commit hash or tag for reproducibility

Copilot · 2025-11-15T14:19:45Z

noterly/pubspec.yaml

+dependency_overrides:
+  intl: ^0.20.2


[nitpick] A dependency_override for intl is forcing version 0.20.2, but the main dependency specifies ^0.19.0. This override is necessary due to dependency conflicts, but it means the app is using a newer version than specified. Consider updating the main dependency to ^0.20.2 to make this explicit and remove the need for the override.

ash-sykes added 8 commits November 11, 2025 21:46

Upgrade to latest flutter version

d40894b

Update gradle version

c691ff9

Remove package from manifest

58fc309

Update gradle build files & dep version

2b9ecd7

Increase gradle memory

eebaa9d

Upgrade various dependency versions

08db788

- Use new version of recieve_share_intent that works with latest flutter - Switch to system_settings_2, a fork that works with latest flutter - Override intl version, to a version that works for latest flutter - Remove firebase

Update manifest to work with latest version of flutter_local_notifica…

ecb7779

…tions

Lots of dart changes

be5178b

Not ideal to mash these together but lots of dart changes, mainly: - Remove firebase - Formatting changes - Add debugging support for notification actions - WIP fix for notification buttons

ash-sykes mentioned this pull request Nov 11, 2025

No longer supported? #41

Open

tomc128 requested a review from Copilot November 15, 2025 14:14

Copilot started reviewing on behalf of tomc128 November 15, 2025 14:15 View session

Copilot finished reviewing on behalf of tomc128 November 15, 2025 14:17

Copilot AI reviewed Nov 15, 2025

View reviewed changes

tomc128 added a commit that referenced this pull request Nov 15, 2025

Selective upgrade from #40

f267b6c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update build#40

Update build#40
ash-sykes wants to merge 8 commits intotomc128:mainfrom
ash-sykes:build

ash-sykes commented Nov 11, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Copilot AI Nov 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-        release {
+        release {
+            // INFO: minifyEnabled was previously set for testing to try and fix splash screen hang issue.
+            // It has been removed because the splash screen hang issue was resolved by other changes (e.g., [specify changes if known]).
+            // If the issue reappears, consider re-adding minifyEnabled false.

	initialValue: _repetitionData.type,
	value: _repetitionData.type,

	var result = await android.requestNotificationsPermission();
	var result = await android.requestPermission();

Uh oh!

Conversation

ash-sykes commented Nov 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants