Mode Modal with optional navigation bar.#19
Open
martin-magakian wants to merge 6 commits intotonisalae:masterfrom
Open
Mode Modal with optional navigation bar.#19martin-magakian wants to merge 6 commits intotonisalae:masterfrom
martin-magakian wants to merge 6 commits intotonisalae:masterfrom
Conversation
Author
|
Remove ARC |
|
Why would you remove ARC? |
Author
|
My project is not using ARC so I changed the code to non ARC. I know you can mix ARC with non ARC but I wanted to be consistante. Feel free to reject my code from 774ce99 if you want to keep ARC. Martin Magakian |
|
This project hasn't been maintained in a lifetime. I've released TSMiniWebBrowser@dblock with a bunch of fixes and will be taking PRs, https://github.com/dblock/TSMiniWebBrowser. It contains the fixes from @DZamataev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it's not interesting for the user experience point of view to display the navigation bar in when push in "ModeModal" so I made it optional.
Also create two button, "Mode Navigation" and "Mode Modal" to make the example easier to understand. Also clean up in the code.