Add test coverage for vortex-wavespec module #25

Copilot · 2026-01-16T21:02:06Z

The vortex-wavespec module lacked test coverage despite having complex coherence calculations and normalization logic. This adds comprehensive tests following patterns established in other quantum-ethics modules.

Test Coverage Added:

runVortexCheck: Validates coherence scoring, node handling, ATOM decision creation, and pass/fail logic
createVortexPayload: Verifies dashboard payload structure, vortex clusters, endpoint statuses, and coherence normalization (0-100 → 0-1 scale)
formatVortexReport: Tests report formatting with various node statuses and pass/fail states
fibonacciCoherenceBoost: Validates boost calculations, capping at 1.0, and edge cases
Integration tests: End-to-end workflow validation

Example test structure:

test('should normalize coherence scores in vortex clusters', () => {
  const payload = createVortexPayload('Test analysis');
  
  payload.vortexes.forEach(vortex => {
    expect(vortex.coherence).toBeGreaterThanOrEqual(0);
    expect(vortex.coherence).toBeLessThanOrEqual(1);
  });
});

32 tests added, all passing. Total quantum-ethics test suite: 74 tests.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: toolate28 <105518313+toolate28@users.noreply.github.com>

github-actions · 2026-01-17T00:20:16Z

🌀 Agent Review: Coherence >60%. Ethical quantum sims validated. Ready for merge.

github-actions · 2026-01-17T00:20:30Z

🌀 Agent Review: Coherence >60%. Ethical quantum sims validated. Ready for merge.

Copilot

Pull request overview

This PR adds comprehensive test coverage for the vortex-wavespec module, which previously lacked tests despite containing complex coherence calculations and normalization logic. The tests follow the established patterns used in other quantum-ethics modules.

Changes:

Added 33 tests covering all exported functions and types from the vortex-wavespec module
Tests validate coherence scoring, normalization (0-100 → 0-1 scale), node handling, ATOM decision creation, and formatting
Includes edge case testing for Fibonacci coherence boost calculations and integration tests for end-to-end workflows

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-17T00:23:43Z

packages/quantum-ethics/src/__tests__/vortex-wavespec.test.ts

+  test('should pass when coherence meets threshold', () => {
+    // This text should generate high coherence score
+    const analysisText = 'Excellent coherence quality metrics with consistent wave patterns and optimal performance indicators demonstrating superior system alignment';
+    const result = runVortexCheck(analysisText);
+
+    // The score should be normalized to 0-1 range
+    expect(result.coherenceScore).toBeGreaterThanOrEqual(0);
+    expect(result.coherenceScore).toBeLessThanOrEqual(1);
+  });


The test name suggests it verifies pass/fail behavior when coherence meets the threshold, but the test only checks that the score is normalized to the 0-1 range. Consider either adding an assertion to verify result.passed is true, or renaming the test to better reflect what it actually tests, such as "should normalize coherence score for high coherence text".

Copilot · 2026-01-17T00:23:43Z

packages/quantum-ethics/src/__tests__/vortex-wavespec.test.ts

+describe('fibonacciCoherenceBoost', () => {
+  test('should boost coherence at iteration 0', () => {
+    const baseCoherence = 0.5;
+    const boosted = fibonacciCoherenceBoost(baseCoherence, 0);
+
+    expect(boosted).toBeGreaterThanOrEqual(baseCoherence);
+    expect(boosted).toBeLessThanOrEqual(1);
+  });
+
+  test('should boost coherence at higher iterations', () => {
+    const baseCoherence = 0.6;
+    const boost1 = fibonacciCoherenceBoost(baseCoherence, 1);
+    const boost2 = fibonacciCoherenceBoost(baseCoherence, 2);
+    const boost3 = fibonacciCoherenceBoost(baseCoherence, 5);
+
+    expect(boost1).toBeGreaterThanOrEqual(baseCoherence);
+    expect(boost2).toBeGreaterThanOrEqual(baseCoherence);
+    expect(boost3).toBeGreaterThanOrEqual(baseCoherence);
+
+    // All should be capped at 1.0
+    expect(boost1).toBeLessThanOrEqual(1);
+    expect(boost2).toBeLessThanOrEqual(1);
+    expect(boost3).toBeLessThanOrEqual(1);
+  });
+
+  test('should cap boost at 1.0', () => {
+    const baseCoherence = 0.95;
+    const boosted = fibonacciCoherenceBoost(baseCoherence, 10);
+
+    expect(boosted).toBe(1);
+  });
+
+  test('should handle low base coherence', () => {
+    const baseCoherence = 0.1;
+    const boosted = fibonacciCoherenceBoost(baseCoherence, 3);
+
+    expect(boosted).toBeGreaterThan(baseCoherence);
+    expect(boosted).toBeLessThanOrEqual(1);
+  });
+
+  test('should handle high iteration counts', () => {
+    const baseCoherence = 0.5;
+    const boosted = fibonacciCoherenceBoost(baseCoherence, 100);
+
+    // Should be capped even with very high iterations
+    expect(boosted).toBeGreaterThanOrEqual(baseCoherence);
+    expect(boosted).toBeLessThanOrEqual(1);
+  });
+
+  test('should produce consistent results', () => {
+    const baseCoherence = 0.7;
+    const iteration = 5;
+
+    const result1 = fibonacciCoherenceBoost(baseCoherence, iteration);
+    const result2 = fibonacciCoherenceBoost(baseCoherence, iteration);
+
+    expect(result1).toBe(result2);
+  });
+
+  test('should increase boost with higher iterations', () => {
+    const baseCoherence = 0.5;
+
+    const boost1 = fibonacciCoherenceBoost(baseCoherence, 1);
+    const boost5 = fibonacciCoherenceBoost(baseCoherence, 5);
+    const boost10 = fibonacciCoherenceBoost(baseCoherence, 10);
+
+    // Later iterations should generally give higher boosts (until cap)
+    expect(boost5).toBeGreaterThanOrEqual(boost1);
+    expect(boost10).toBeGreaterThanOrEqual(boost5);
+  });
+
+  test('should handle zero base coherence', () => {
+    const baseCoherence = 0;
+    const boosted = fibonacciCoherenceBoost(baseCoherence, 5);
+
+    expect(boosted).toBeGreaterThanOrEqual(0);
+    expect(boosted).toBeLessThanOrEqual(1);
+  });
+
+  test('should handle perfect base coherence', () => {
+    const baseCoherence = 1.0;
+    const boosted = fibonacciCoherenceBoost(baseCoherence, 5);
+
+    // Should remain at 1.0
+    expect(boosted).toBe(1);
+  });
+});


The tests for fibonacciCoherenceBoost do not cover negative iteration values. The implementation uses FIBONACCI[fibIndex] without validating that the iteration is non-negative, which could lead to undefined behavior. Consider adding a test case for negative iterations to ensure the function handles this edge case gracefully.

toolate28 · 2026-01-18T04:41:39Z

@copilot apply changes based on the comments in this thread

Copilot AI assigned Copilot and toolate28 Jan 16, 2026

Copilot AI mentioned this pull request Jan 16, 2026

Copilot/sub pr 8 again #24

Merged

Copilot started work on behalf of toolate28 January 16, 2026 21:02 View session

Copilot AI changed the title ~~[WIP] WIP addressing feedback from PR #24~~ Add test coverage for vortex-wavespec module Jan 16, 2026

Copilot AI requested a review from toolate28 January 16, 2026 21:08

Copilot finished work on behalf of toolate28 January 16, 2026 21:08

Add comprehensive test coverage for vortex-wavespec module

ff3287e

Co-authored-by: toolate28 <105518313+toolate28@users.noreply.github.com>

toolate28 force-pushed the copilot/sub-pr-24 branch from c196894 to ff3287e Compare January 17, 2026 00:20

toolate28 marked this pull request as ready for review January 17, 2026 00:20

Copilot AI review requested due to automatic review settings January 17, 2026 00:20

toolate28 approved these changes Jan 17, 2026

View reviewed changes

Copilot started reviewing on behalf of toolate28 January 17, 2026 00:20 View session

toolate28 merged commit 44b9812 into copilot/sub-pr-8-again Jan 17, 2026
5 checks passed

toolate28 deleted the copilot/sub-pr-24 branch January 17, 2026 00:20

Copilot AI reviewed Jan 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test coverage for vortex-wavespec module #25

Add test coverage for vortex-wavespec module #25

Uh oh!

Copilot AI commented Jan 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 17, 2026

Uh oh!

Copilot AI Jan 17, 2026

Uh oh!

toolate28 commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add test coverage for vortex-wavespec module #25

Add test coverage for vortex-wavespec module #25

Uh oh!

Conversation

Copilot AI commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

toolate28 commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 16, 2026 •

edited

Loading