Replace magic number coherence boosts with formula-based VortexCriticality system

[Copilot]

The createVortexPayload function used undocumented magic numbers (+0.05, +0.03, +0.08) for coherence boosts, making the code difficult to maintain and understand.

Changes:

• Added VortexCriticality enum defining criticality levels (0-8) with rationale for each vortex type
• Added calculateCoherenceBoost(criticality) function: boost = criticality / 100
• Refactored coherence calculations to use formula instead of hardcoded offsets

Before:

coherence: Math.min(1, normalizeCoherenceScore(waveAnalysis.coherence_score) + 0.05)

After:

enum VortexCriticality {
  MONITORING = 0, // Baseline - observational role
  PLANNING = 3,   // Infrastructure planning requires moderate stability
  TESTING = 5,    // Testing/compliance needs high reliability
  CORE = 8,       // Core ethics requires maximum coherence
}

coherence: Math.min(1, baseCoherence + calculateCoherenceBoost(VortexCriticality.TESTING))

Values remain mathematically identical, but the rationale is now explicit and maintainable.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[github-actions]

🌀 Agent Review: Coherence >60%. Ethical quantum sims validated. Ready for merge.

[Copilot]

Pull request overview

This PR refactors magic number coherence boosts in the createVortexPayload function by introducing a formula-based VortexCriticality system. The change improves code maintainability by replacing undocumented hardcoded values (+0.05, +0.03, +0.08) with an explicit enum and calculation function, while maintaining mathematical equivalence.

Changes:

• Introduced VortexCriticality enum with four criticality levels (0, 3, 5, 8) and documentation for each vortex type
• Added calculateCoherenceBoost() helper function implementing the formula boost = criticality / 100
• Refactored coherence calculations in all four vortex clusters to use the new formula-based system

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.