Fix workflow to only post success comment when simulation passes #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Copilot
AI
changed the title
[WIP] Update to address feedback from PR #24
Fix workflow to only post success comment when simulation passes
Jan 16, 2026
toolate28
approved these changes
Jan 17, 2026
Co-authored-by: toolate28 <105518313+toolate28@users.noreply.github.com>
toolate28
force-pushed
the
copilot/sub-pr-24-98f381fd-de32-439e-a71f-7eaf202ef724
branch
from
3af9746 to
fd63e81
Compare
toolate28
deleted the
copilot/sub-pr-24-98f381fd-de32-439e-a71f-7eaf202ef724
branch
|
🌀 Agent Review: Coherence >60%. Ethical quantum sims validated. Ready for merge. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the workflow behavior so that "Ready for merge" comments are only posted when the ethical simulation step has actually succeeded on pull requests.
Changes:
- Updated the "Comment on PR" step in
.github/workflows/coding-agent.ymlto add a condition onsteps.simulate.outcome == 'success'in addition to checking forpull_requestevents. - Ensures failure (or non-success) outcomes in the simulation step prevent the success comment from being posted.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow unconditionally posted "Ready for merge" comments on all PRs, even when ethical simulations failed.
Changes
steps.simulate.outcome == 'success'condition to the "Comment on PR" step in.github/workflows/coding-agent.ymlThe workflow now only posts success comments when the simulation step completes successfully.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.