avoid nnNode:label() error for string data#152
Open
kruus wants to merge 2 commits intotorch:masterfrom
Open
Conversation
making a local copy of string data allows luajit to avoid errors such as: .../torch/install/bin/luajit: .../install/share/lua/5.1/nngraph/node.lua:143: bad argument torch#2 to 'insert' (number expected, got string)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple 1-line "robustness" PR (and associated test)
Original nngraph with luajit was giving me the following error for labelling a table containing a string value:
This error can happen with the following test program, and something similar has been added to tests/test_nngraph.lua
Luajit runs this fine if the getstr('some string') first goes into a local variable, and then into
table.insert.Dunno' why.