Fix error when message contains NUL bytes#5
Open
sbilharz wants to merge 3 commits intotoretore:masterfrom
Open
Fix error when message contains NUL bytes#5sbilharz wants to merge 3 commits intotoretore:masterfrom
sbilharz wants to merge 3 commits intotoretore:masterfrom
Conversation
strlen stops at the first NUL byte which breaks getting a proper grid when the message contains any of them. The message length is known at this point and can be passed to iec16022init instead of the message pointer.
It seems odd to believe the underlying library has a bug requires us to always append a blank at the end of the input. There might be some edge cases where this is necessary but I did not encounter any so far.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strlen stops at the first NUL byte which breaks getting a proper grid
when the message contains any of them. The message length is known at
this point and can be passed to iec16022init instead of the message
pointer.
Edit: I now also removed the workaround that appended a blank to every input string. The
strcatmethod also can't handle NUL bytes and I couldn't find a use case where this sort of fiddling was necessary in the first place.