Adding Contribution Guidelines to Tornado Web Server#2675
Open
nbmason14 wants to merge 3 commits intotornadoweb:masterfrom
Open
Adding Contribution Guidelines to Tornado Web Server#2675nbmason14 wants to merge 3 commits intotornadoweb:masterfrom
nbmason14 wants to merge 3 commits intotornadoweb:masterfrom
Conversation
added 3 commits
June 9, 2019 00:13
After reading through the repository I saw a request to add contribution guidelines so decided to create them. This is one of my first contributions so I may be missing information, if so please let me know what I should add/edit to make this acceptable
Member
|
This seems fine, but it's fairly generic. If this is all CONTRIBUTING.md is going to say, I'd rather just link to some generic contribute-to-open-source documentation. But instead, we should probably add some tornado-specific details:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the issue listed here: #2668 I have taken a first pass at Contribution Guidelines for Tornado Web Server
If I am missing key information or need to make any edits please let me know and I will fix them