fix WebSocketClientConnection circle reference to itself#2865
Open
qcha0 wants to merge 7 commits intotornadoweb:masterfrom
Open
fix WebSocketClientConnection circle reference to itself#2865qcha0 wants to merge 7 commits intotornadoweb:masterfrom
qcha0 wants to merge 7 commits intotornadoweb:masterfrom
Conversation
bdarnell
reviewed
Jun 19, 2020
Member
bdarnell
left a comment
bdarnell
left a comment
There was a problem hiding this comment.
The mypy annotations need updating to reflect that this attribute is now optional.
I wish Future were actually two types, one for the setters and one for the getters.
qcha0
force-pushed
the
hotfix/break-reference-websocket-itself
branch
from
e932d0d to
8564b21
Compare
qcha0
force-pushed
the
hotfix/break-reference-websocket-itself
branch
from
8564b21 to
84cc2a1
Compare
qcha0
force-pushed
the
hotfix/break-reference-websocket-itself
branch
from
33e1dc0 to
0087604
Compare
qcha0
force-pushed
the
hotfix/break-reference-websocket-itself
branch
from
0087604 to
5296bd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.