Add StreamingMultipartFormDataParser.#3228
Open
eulersIDcrisis wants to merge 8 commits intotornadoweb:masterfrom
Open
Add StreamingMultipartFormDataParser.#3228eulersIDcrisis wants to merge 8 commits intotornadoweb:masterfrom
eulersIDcrisis wants to merge 8 commits intotornadoweb:masterfrom
Conversation
Still need to fix the tests and also improve Awaitable vs. None interface.
Also, fix the tests to start passing now.
…dd-streaming-multipart-form-data
…dd-streaming-multipart-form-data
Contributor
Author
|
One way this PR could be improved is if class BufferedStream:
def __init__(self):
self._chunks = deque()
def append(chunk: bytes):
self._chunks.append(chunk)
def read_next_until(self, match: bytes) -> Optional[bytes]:
# Calls to
If this class were implemented properly, this could avoid some spurious copies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a basic
multipart/form-dataparser to tornado that can stream to files instead of in-memory as the existing call to:tornado.httputil.parse_multipart_form_datadoes.