Fix respawn function not working by switching it to node's spawn#6
Open
Khotul wants to merge 1 commit intotowerstorm:masterfrom
Open
Fix respawn function not working by switching it to node's spawn#6Khotul wants to merge 1 commit intotowerstorm:masterfrom
Khotul wants to merge 1 commit intotowerstorm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respawn function is broken, doesn't actually run any of the node apps, and doesn't show any error.
I don't know the exact cause of this. I believe this may either be caused by old "Respawn" package being incompatible with newer npm versions, or Windows incompatibility with some of the functions that were coded directly for Linux-based systems.
Either way, replacing this function with node's internal Spawn function gets rids of this issue.
(Todo: this issue should be looked in further to reimplement the respawning of crashed processes. For now this fix is enough, as having an app that doesn't restart is better than one that doesn't run in the first place)