Open
Conversation
KamilBalwierz
requested changes
Mar 3, 2026
| $this->tpayService = $tpayService; | ||
| $this->tokensService = $tokensService; | ||
| $this->tpay = $tpayModel; | ||
| $this->tpay = $tpay; |
Contributor
There was a problem hiding this comment.
name have changed, but no other changes in this file - so this is unused dependency?
Contributor
Author
There was a problem hiding this comment.
its used in line 55, only name of parameter changed, property still has same name
| if ($orderId) { | ||
| $storeId = $this->getOrderStore($orderId); | ||
| } | ||
| $defaultStoreId = $this->storeManager->getDefaultStoreView()->getId(); |
Contributor
There was a problem hiding this comment.
As this is called within controller it should have correct store resolved already by system.
It should be safe to assume that $this->storeManager->getCurrentStoreId() is correct store id for notification (based on URL generated during transaction creation it should have proper domain / store code in address)
|
|
||
| $strategy = $this->factory->create($notification); | ||
|
|
||
| $strategy->process($storeId); |
Contributor
There was a problem hiding this comment.
looks like all implementations of strategy have process($notification, ? $storeId) declaration now
KamilBalwierz
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.