Skip to content

tpluspy: Add rollback_reason to get_user_trades #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
farnyser merged 1 commit into from
Mar 6, 2026
Merged

tpluspy: Add rollback_reason to get_user_trades #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tplus/model/trades.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class UserTrade(BaseModel):
is_maker: bool = Field(..., description="True if this user was the maker")
is_buyer: bool = Field(..., description="True if this user was the buyer")
status: Literal["Pending", "Confirmed", "Rollbacked"]
rollback_reason: str | None

@property
def buyer_is_maker(self) -> bool:
Expand Down Expand Up @@ -106,6 +107,7 @@ def parse_single_user_trade(item: dict[str, Any]) -> UserTrade:
is_maker=bool(item["is_maker"]),
is_buyer=bool(item["is_buyer"]),
status=item["status"],
rollback_reason=item["rollback_reason"],
)
except (KeyError, ValueError, TypeError) as e:
raise ValueError(f"Invalid user trade data: {item}") from e
Expand Down