Skip to content

Initial reusable linting workflow#6

Merged
woodruffw merged 19 commits intomainfrom
ww/reusable-demo
Jan 19, 2023
Merged

Initial reusable linting workflow#6
woodruffw merged 19 commits intomainfrom
ww/reusable-demo

Conversation

@woodruffw
Copy link
Contributor

@woodruffw woodruffw commented Jan 13, 2023

No description provided.

@woodruffw
[WIP] README, workflows: experimentation
97bc055 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
workflows/lint: configure python optionally
2b7f871 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
lint: be even more normative about Python
218350a 
...we use `pyproject.toml` and `pip`, so we can safely
set these caching settings.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
workflows/lint: add a TODO
7d43b79 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
lint: remove TODO
3020cc3 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
workflows/lint: cargo fmt -> cargo clippy
ede8697 
`cargo fmt` should go in a separate workflow.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
lint: reuse clippy-check for clippy
5705c90 
This has support for annotations, which is the kind of
thing we want!

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
workflows/lint: avoid unmaintained clippy-check
a2f849b 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
workflows/lint: note
6766756 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
lint: cargo-sort support
90ae18c 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
lint: typo
7c04c8f 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
lint: testing
6d069e4 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Revert "lint: testing"
34bb1a9 
This reverts commit 6d069e4.
@woodruffw
workflows/lint: fix evaluation
ada2eb5 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
lint: make clippy fail on warnings
e48d2d1 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
lint: add rustfmt, remove redundant token
3c66e09 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Contributor Author

woodruffw commented Jan 18, 2023 •
edited
Loading

NB: We can also set RUFF_FORMAT=github to enable ruff's GitHub annotations; I'll add this in at some point.

Edit: Done.

@CLAassistant
Copy link

CLAassistant commented Jan 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@woodruffw
lint: add RUFF_FORMAT
2aa1af1 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw marked this pull request as ready for review January 18, 2023 21:34
@woodruffw woodruffw changed the title WIP: Reusable linting workflow demo Reusable linting workflow demo Jan 18, 2023
@woodruffw woodruffw changed the title Reusable linting workflow demo Initial reusable linting workflow Jan 18, 2023
@woodruffw
Copy link
Contributor Author

woodruffw commented Jan 18, 2023

Demos:

@woodruffw
workflows/lint: workflow-level env
9283d51 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Contributor Author

woodruffw commented Jan 18, 2023

Screencap of annotations for Python:

Screenshot 2023-01-18 at 4 46 25 PM

This was referenced Jan 18, 2023
Merged
Open
@woodruffw woodruffw merged commit 9b67f9d into main Jan 19, 2023
@woodruffw woodruffw deleted the ww/reusable-demo branch January 19, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artemdinaburg artemdinaburg Awaiting requested review from artemdinaburg

@oldsj oldsj Awaiting requested review from oldsj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@woodruffw @CLAassistant