Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Auth Files API#102

Open
rschumann wants to merge 2 commits intomainfrom
sentinel-path-traversal-auth-8781413356012186276
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Auth Files API#102
rschumann wants to merge 2 commits intomainfrom
sentinel-path-traversal-auth-8781413356012186276

Conversation

@rschumann
Copy link
Contributor

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Cross-platform path traversal vulnerability. The UploadAuthFile and DeleteAuthFile APIs relied on strings.Contains(name, string(os.PathSeparator)) to sanitize filenames. On Windows, os.PathSeparator is \ meaning / is permitted, allowing an attacker to supply a payload like ../../secrets/file.json and traverse directories. In UploadAuthFile, file.Filename wasn't explicitly verified.
🎯 Impact: Malicious actors could delete or replace arbitrary .json files outside the designated AuthDir directory on Windows hosts if the API relies on local paths, potentially compromising internal keys and data or triggering Denial of Service (DoS) by wiping configuration.
πŸ”§ Fix: Replaced strings.Contains with strings.ContainsAny(name, "/\\") for both queries and form payloads. Validates file.Filename explicitly alongside the query params.
βœ… Verification: Verified by existing security unit tests (auth_files_security_test.go) and standard go test ./... -short which are confirmed to pass properly with this security check.


PR created automatically by Jules for task 8781413356012186276 started by @rschumann

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant