Skip to content

🛡️ Sentinel: [CRITICAL] Fix path traversal vulnerability in auth file management#89

Open
rschumann wants to merge 2 commits intomainfrom
sentinel-fix-path-traversal-12121560632116789410
Open

🛡️ Sentinel: [CRITICAL] Fix path traversal vulnerability in auth file management#89
rschumann wants to merge 2 commits intomainfrom
sentinel-fix-path-traversal-12121560632116789410

Conversation

@rschumann
Copy link
Contributor

🚨 Severity: CRITICAL
💡 Vulnerability: Path Traversal in UploadAuthFile and DeleteAuthFile.
The previous validation used strings.Contains(name, string(os.PathSeparator)) which only checks for the separator of the host OS. This allowed attackers to use the alternative separator (e.g., \ on Linux or / on Windows) to bypass the check, potentially leading to arbitrary file write or deletion (especially on Windows where both separators are valid).

🎯 Impact: An attacker could overwrite or delete critical system files if the server is running on Windows, or create files outside the intended directory.

🔧 Fix: Updated the validation to use strings.ContainsAny(name, "/\\") which explicitly rejects both forward and backward slashes on all platforms.

Verification: Added a new regression test TestAuthFiles_PathTraversal in internal/api/handlers/management/auth_files_security_test.go that verifies both separator types are rejected.


PR created automatically by Jules for task 12121560632116789410 started by @rschumann

… management

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…rability

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant