π‘οΈ Sentinel: [HIGH] Fix path traversal in auth file operations#97
π‘οΈ Sentinel: [HIGH] Fix path traversal in auth file operations#97
Conversation
Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: Path traversal vulnerability in
UploadAuthFileandDeleteAuthFilemanagement endpoints. The previous code relied onos.PathSeparatorto validate file names, which can be bypassed (e.g., passing/on a Windows host or\in mixed environments).π― Impact: An attacker could potentially upload arbitrary JSON files to other directories or delete arbitrary JSON files on the system if they have access to the management endpoint.
π§ Fix: Changed the path validation check to
strings.ContainsAny(name, "/\\")to robustly prevent directory traversal attempts across all platforms. This matches the existing secure logic inDownloadAuthFile. Added unit tests inauth_files_security_test.goto explicitly verify the path traversal protection.β Verification: Run
go test ./internal/api/handlers/management -run "TestUploadAuthFile_PathTraversal|TestDeleteAuthFile_PathTraversal" -vto ensure the unit tests pass and properly reject path traversal payloads.PR created automatically by Jules for task 11016025934345615142 started by @rschumann