Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix path traversal in auth file operations#97

Open
rschumann wants to merge 2 commits intomainfrom
sentinel/fix-path-traversal-auth-files-11016025934345615142
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix path traversal in auth file operations#97
rschumann wants to merge 2 commits intomainfrom
sentinel/fix-path-traversal-auth-files-11016025934345615142

Conversation

@rschumann
Copy link
Contributor

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Path traversal vulnerability in UploadAuthFile and DeleteAuthFile management endpoints. The previous code relied on os.PathSeparator to validate file names, which can be bypassed (e.g., passing / on a Windows host or \ in mixed environments).
🎯 Impact: An attacker could potentially upload arbitrary JSON files to other directories or delete arbitrary JSON files on the system if they have access to the management endpoint.
πŸ”§ Fix: Changed the path validation check to strings.ContainsAny(name, "/\\") to robustly prevent directory traversal attempts across all platforms. This matches the existing secure logic in DownloadAuthFile. Added unit tests in auth_files_security_test.go to explicitly verify the path traversal protection.
βœ… Verification: Run go test ./internal/api/handlers/management -run "TestUploadAuthFile_PathTraversal|TestDeleteAuthFile_PathTraversal" -v to ensure the unit tests pass and properly reject path traversal payloads.


PR created automatically by Jules for task 11016025934345615142 started by @rschumann

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant