fix(run-engine): use reader for pending version queries by ericallam · Pull Request #2924 · triggerdotdev/trigger.dev

ericallam · 2026-01-21T14:43:10Z

Move expensive findMany queries for PENDING_VERSION and WAITING_FOR_DEPLOY
runs to read replicas to avoid blocking migrations on the primary database.

Changes:

Add readOnlyPrisma to SystemResources type
Pass readOnlyPrisma to systems in RunEngine constructor
Update pendingVersionSystem to use readOnlyPrisma for findMany
Update executeTasksWaitingForDeploy to use _replica for findMany

Move expensive findMany queries for PENDING_VERSION and WAITING_FOR_DEPLOY runs to read replicas to avoid blocking migrations on the primary database. Changes: - Add readOnlyPrisma to SystemResources type - Pass readOnlyPrisma to systems in RunEngine constructor - Update pendingVersionSystem to use readOnlyPrisma for findMany - Update executeTasksWaitingForDeploy to use _replica for findMany

changeset-bot · 2026-01-21T14:43:15Z

⚠️ No Changeset found

Latest commit: dc28109

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-01-21T14:43:45Z

Walkthrough

This pull request introduces read-only Prisma replica client support across the system. Changes include: adding readOnlyPrisma: PrismaReplicaClient to the SystemResources type definition, passing the read-only client through engine initialization, and switching specific read operations from the writable Prisma client to the replica client in task run queries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description clearly explains the motivation and lists specific changes, but omits required template sections like Testing, Changelog, and the checklist.	Complete the PR description template by adding the Testing section, Changelog section, and filling out the checklist items to document verification and changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main objective: moving pending version queries to use replica readers to avoid blocking primary database migrations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd2f536 and dc28109.

📒 Files selected for processing (4)

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts
internal-packages/run-engine/src/engine/index.ts
internal-packages/run-engine/src/engine/systems/pendingVersionSystem.ts
internal-packages/run-engine/src/engine/systems/systems.ts

🧰 Additional context used

📓 Path-based instructions (7)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

**/*.{ts,tsx}: Always import tasks from @trigger.dev/sdk, never use @trigger.dev/sdk/v3 or deprecated client.defineJob pattern
Every Trigger.dev task must be exported and have a unique id property with no timeouts in the run function

Files:

internal-packages/run-engine/src/engine/systems/pendingVersionSystem.ts
internal-packages/run-engine/src/engine/systems/systems.ts
apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts
internal-packages/run-engine/src/engine/index.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

Import from @trigger.dev/core using subpaths only, never import from root

Files:

internal-packages/run-engine/src/engine/systems/pendingVersionSystem.ts
internal-packages/run-engine/src/engine/systems/systems.ts
apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts
internal-packages/run-engine/src/engine/index.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)

**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries

Files:

internal-packages/run-engine/src/engine/systems/pendingVersionSystem.ts
internal-packages/run-engine/src/engine/systems/systems.ts
apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts
internal-packages/run-engine/src/engine/index.ts

**/*.{js,ts,jsx,tsx,json,md,yaml,yml}

📄 CodeRabbit inference engine (AGENTS.md)

Format code using Prettier before committing

Files:

internal-packages/run-engine/src/engine/systems/pendingVersionSystem.ts
internal-packages/run-engine/src/engine/systems/systems.ts
apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts
internal-packages/run-engine/src/engine/index.ts

{packages/core,apps/webapp}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use zod for validation in packages/core and apps/webapp

Files:

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

apps/webapp/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

Access all environment variables through the env export of env.server.ts instead of directly accessing process.env in the Trigger.dev webapp

Files:

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

apps/webapp/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

apps/webapp/**/*.{ts,tsx}: When importing from @trigger.dev/core in the webapp, use subpath exports from the package.json instead of importing from the root path
Follow the Remix 2.1.0 and Express server conventions when updating the main trigger.dev webapp

Access environment variables via env export from apps/webapp/app/env.server.ts, never use process.env directly

Files:

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

🧠 Learnings (15)

📓 Common learnings

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 2264
File: apps/webapp/app/services/runsRepository.server.ts:172-174
Timestamp: 2025-07-12T18:06:04.133Z
Learning: In apps/webapp/app/services/runsRepository.server.ts, the in-memory status filtering after fetching runs from Prisma is intentionally used as a workaround for ClickHouse data delays. This approach is acceptable because the result set is limited to a maximum of 100 runs due to pagination, making the performance impact negligible.

📚 Learning: 2025-07-12T18:06:04.133Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 2264
File: apps/webapp/app/services/runsRepository.server.ts:172-174
Timestamp: 2025-07-12T18:06:04.133Z
Learning: In apps/webapp/app/services/runsRepository.server.ts, the in-memory status filtering after fetching runs from Prisma is intentionally used as a workaround for ClickHouse data delays. This approach is acceptable because the result set is limited to a maximum of 100 runs due to pagination, making the performance impact negligible.

Applied to files:

internal-packages/run-engine/src/engine/systems/pendingVersionSystem.ts
apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

📚 Learning: 2026-01-15T11:50:06.067Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-15T11:50:06.067Z
Learning: Applies to internal-packages/database/prisma/migrations/**/*.sql : When editing the Prisma schema, remove extraneous migration lines related to specific tables: `_BackgroundWorkerToBackgroundWorkerFile`, `_BackgroundWorkerToTaskQueue`, `_TaskRunToTaskRunTag`, `_WaitpointRunConnections`, `_completedWaitpoints`, `SecretStore_key_idx`, and unrelated `TaskRun` indexes

Applied to files:

internal-packages/run-engine/src/engine/systems/pendingVersionSystem.ts
apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

📚 Learning: 2025-11-27T16:26:37.432Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T16:26:37.432Z
Learning: Applies to internal-packages/database/**/*.{ts,tsx} : Use Prisma for database interactions in internal-packages/database with PostgreSQL

Applied to files:

internal-packages/run-engine/src/engine/systems/pendingVersionSystem.ts
internal-packages/run-engine/src/engine/systems/systems.ts
internal-packages/run-engine/src/engine/index.ts

📚 Learning: 2025-11-27T16:26:58.661Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-11-27T16:26:58.661Z
Learning: Leverage the PostgreSQL database through the `trigger.dev/database` Prisma 6.14.0 client in the webapp for all data access patterns

Applied to files:

internal-packages/run-engine/src/engine/systems/systems.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use logger methods (debug, log, info, warn, error) from `trigger.dev/sdk/v3` for structured logging in tasks

Applied to files:

internal-packages/run-engine/src/engine/systems/systems.ts

📚 Learning: 2025-11-27T16:26:37.432Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T16:26:37.432Z
Learning: Applies to packages/trigger-sdk/**/*.{ts,tsx} : In the Trigger.dev SDK (packages/trigger-sdk), prefer isomorphic code like fetch and ReadableStream instead of Node.js-specific code

Applied to files:

internal-packages/run-engine/src/engine/systems/systems.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Export tasks with unique IDs within the project to enable proper task discovery and execution

Applied to files:

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

📚 Learning: 2026-01-15T11:50:06.067Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-15T11:50:06.067Z
Learning: Applies to **/*.{ts,tsx} : Always import tasks from `trigger.dev/sdk`, never use `trigger.dev/sdk/v3` or deprecated `client.defineJob` pattern

Applied to files:

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use the `task()` function from `trigger.dev/sdk/v3` to define tasks with id and run properties

Applied to files:

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `schedules.task()` for scheduled/cron tasks instead of regular `task()`

Applied to files:

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

📚 Learning: 2026-01-15T11:50:06.067Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-15T11:50:06.067Z
Learning: Applies to **/*.{ts,tsx} : Every Trigger.dev task must be exported and have a unique `id` property with no timeouts in the run function

Applied to files:

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `.withStreams()` to subscribe to realtime streams from task metadata in addition to run changes

Applied to files:

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Attach metadata to task runs using the metadata option when triggering, and access/update it inside runs using metadata functions

Applied to files:

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Subscribe to run updates using `runs.subscribeToRun()` for realtime monitoring of task execution

Applied to files:

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)

GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
GitHub Check: typecheck / typecheck
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (5)

internal-packages/run-engine/src/engine/systems/systems.ts (1)

3-3: LGTM!

Clean type extension to support read-only Prisma client access. The use of type over interface aligns with the coding guidelines.

Also applies to: 10-21

internal-packages/run-engine/src/engine/systems/pendingVersionSystem.ts (1)

53-69: Appropriate use of read replica for the expensive findMany query.

The read-only client is correctly applied only to the bulk read operation while write operations (Lines 88-96 transaction) remain on the primary.

One consideration: with replication lag, subsequent batch iterations (Line 125-127) might re-fetch runs that were just updated to PENDING. However, this is mitigated by:

The PENDING_VERSION status filter will exclude already-processed runs once replication catches up

The update at Line 89-96 is idempotent (setting status to PENDING on an already-PENDING run is a no-op functionally)

internal-packages/run-engine/src/engine/index.ts (2)

109-109: Good fallback pattern for backward compatibility.

The fallback options.readOnlyPrisma ?? this.prisma ensures existing consumers that don't provide a read-only client will continue to work seamlessly.

269-280: LGTM!

The readOnlyPrisma is correctly propagated through the SystemResources object, making it available to all downstream systems.

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts (1)

36-58: Correct separation of read operation to replica.

The expensive findMany query is appropriately moved to the read replica while the updateMany write operation correctly remains on the primary client. The _replica property is properly defined on BaseService and initialized with the read replica client from the database module.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vibe-kanban-cloud · 2026-01-21T14:46:38Z

Review Complete

Your review story is ready!

View Story

Comment !reviewfast on this PR to re-generate the story.

ericallam changed the title ~~fix(run-engine): use replica for pending version queries~~ fix(run-engine): use reader for pending version queries Jan 21, 2026

ericallam marked this pull request as ready for review January 21, 2026 15:18

mpcgrid approved these changes Jan 21, 2026

View reviewed changes

matt-aitken approved these changes Jan 21, 2026

View reviewed changes

ericallam merged commit 6f26acb into main Jan 21, 2026
33 checks passed

ericallam deleted the fix/use-replica-for-pending-version-queries branch January 21, 2026 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(run-engine): use reader for pending version queries#2924

fix(run-engine): use reader for pending version queries#2924
ericallam merged 1 commit intomainfrom
fix/use-replica-for-pending-version-queries

ericallam commented Jan 21, 2026

Uh oh!

changeset-bot bot commented Jan 21, 2026

Uh oh!

coderabbitai bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

vibe-kanban-cloud bot commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Comments

Conversation

ericallam commented Jan 21, 2026

Uh oh!

changeset-bot bot commented Jan 21, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Uh oh!

vibe-kanban-cloud bot commented Jan 21, 2026

Review Complete

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Jan 21, 2026 •

edited

Loading