Fix issue when response contains a node with the same name as an existing class#1
Open
gonfva wants to merge 1 commit intotripit:masterfrom
Open
Fix issue when response contains a node with the same name as an existing class#1gonfva wants to merge 1 commit intotripit:masterfrom
gonfva wants to merge 1 commit intotripit:masterfrom
Conversation
If we receive a response like <Response><timestamp>1394617345</timestamp><num_bytes>6625</num_bytes><Trip>.... and we have an existing class called Trip, the process could crash while trying to create the Trip object. The code in TravelObj#new tries to get and crate constants that belongs to a module, but it does it inheriting. The change just avoids inheriting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we receive a response like
<Response><timestamp>1394617345</timestamp><num_bytes>6625</num_bytes><Trip>....and we have an existing class called
Trip, the process could crash while trying to create theTripobject. The code inTravelObj#newtries to get and crate constants that belongs to a module, but it does it inheriting. This change just avoids inheriting, so that it looks only in the module.