Skip to content

Conversation

@otoge-anon
Copy link

commit is self-explanatory

Copy link
Owner

@trmazi trmazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few issues with this file.

  1. Clean up the imports please
  2. Please make sure that the 3 inputs are uppercase
  3. Make sure that all 3 checks have exit()
  4. CompileDong is expecting the mcode in an array, not a full string.
def makeBlackDong(key:str, mcode:list, pcbid):

Also, if you reread CompileDong, you'll see that there's actually a slightly different signing process for making a white dongle, and making one in the same way as a black dongle will not work. You'll need to separate them somehow.

@otoge-anon
Copy link
Author

1, 2, 3: ok
4: output is the same.
5: it's only using makeBlackDong.

@trmazi
Copy link
Owner

trmazi commented Jan 5, 2022

Thanks for the changes, and about the last one, makeBlackDong will not work if you are trying to make a white dong. The black dongles add the mcode to the sign key, white dongles do not. The game will not work with that.

Lastly, please add .bin to the output filename.

Other than that, tested working (only for black dongles)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants