add car sharing project by trokhim03 · Pull Request #1 · trokhim03/CarSharing-API

trokhim03 · 2025-05-05T11:22:51Z

No description provided.

Elena-Bruyako

Good job! Let's first fix comments in main code
Add readme file

Elena-Bruyako · 2025-05-06T17:44:43Z

pom.xml

+        <dependency>
+            <groupId>org.mapstruct</groupId>
+            <artifactId>mapstruct</artifactId>
+            <version>1.6.3</version>


replace to properties

Elena-Bruyako · 2025-05-06T17:44:48Z

pom.xml

+        <dependency>
+            <groupId>org.mapstruct</groupId>
+            <artifactId>mapstruct-processor</artifactId>
+            <version>1.6.3</version>


Elena-Bruyako · 2025-05-06T17:45:05Z

pom.xml

+                        <path>
+                            <groupId>org.projectlombok</groupId>
+                            <artifactId>lombok</artifactId>
+                            <version>1.18.30</version>


same here (for all places)

Elena-Bruyako · 2025-05-06T17:45:19Z

src/main/java/mate/academy/carsharing/controller/AuthController.java

+            description = "Register a new user with email, password and other details")
+    @PostMapping("/registration")
+    public UserResponseDto registration(
+            @RequestBody UserRegistrationRequestDto userRegistrationRequestDto)


Suggested change

@RequestBody UserRegistrationRequestDto userRegistrationRequestDto)

@RequestBody @Valid UserRegistrationRequestDto userRegistrationRequestDto)

Elena-Bruyako · 2025-05-06T17:45:31Z

src/main/java/mate/academy/carsharing/controller/AuthController.java

+    @Operation(summary = "Login user",
+            description = "Authenticate user and return JWT token")
+    @PostMapping("/login")
+    public UserLoginResponseDto login(@RequestBody UserLoginRequestDto userLoginRequestDto) {


Suggested change

public UserLoginResponseDto login(@RequestBody UserLoginRequestDto userLoginRequestDto) {

public UserLoginResponseDto login(@RequestBody @Valid UserLoginRequestDto userLoginRequestDto) {

Elena-Bruyako · 2025-05-06T17:51:30Z

src/main/java/mate/academy/carsharing/model/User.java

+    @Column(name = "first_name", nullable = false)
+    private String firstName;
+
+    @Column(name = "last_name", nullable = false)


Suggested change

@Column(name = "first_name", nullable = false)

private String firstName;

@Column(name = "last_name", nullable = false)

@Column(nullable = false)

private String firstName;

@Column(nullable = false)

Elena-Bruyako · 2025-05-06T17:52:31Z

src/main/java/mate/academy/carsharing/service/payment/PaymentServiceImpl.java

+    public Page<PaymentResponseDto> getWithUserId(Pageable pageable, Long userId) {
+        return paymentRepository.findAllByRental_UserId(pageable, userId)
+                .map(paymentMapper::toDto);
+


remove redundant empty line

Suggested change

public Page<PaymentResponseDto> getWithUserId(Pageable pageable, Long userId) {

return paymentRepository.findAllByRental_UserId(pageable, userId)

.map(paymentMapper::toDto);

public Page<PaymentResponseDto> getWithUserId(Pageable pageable, Long userId) {

return paymentRepository.findAllByRental_UserId(pageable, userId)

.map(paymentMapper::toDto);

Elena-Bruyako · 2025-05-06T17:52:51Z

src/main/java/mate/academy/carsharing/service/payment/PaymentServiceImpl.java

+        payment.setSessionId("none");
+        payment.setSessionUrl("http://none.none");
+
+        payment = paymentRepository.save(payment);


Suggested change

payment = paymentRepository.save(payment);

paymentRepository.save(payment);

Elena-Bruyako · 2025-05-06T17:53:15Z

src/main/java/mate/academy/carsharing/service/payment/PaymentServiceImpl.java

+                        "Can't find payment by id: " + paymentId));
+
+        if (payment.getStatus() == Payment.Status.PAID) {
+            return;


is it expected behaviour?

Elena-Bruyako · 2025-05-06T17:54:36Z

src/main/java/mate/academy/carsharing/service/user/UserServiceImpl.java

+        user.setPassword(passwordEncoder.encode(userRegistrationRequestDto.getPassword()));
+
+        Role defaultRole = roleRepository.findByName(Role.RoleName.CUSTOMER)
+                .orElseThrow(() -> new EntityNotFoundException("Default role not found"));


use CUSTOMER for message

liliia-ponomarenko

Good job! A few comments ;) Also, you can improve test coverage

liliia-ponomarenko · 2025-05-12T09:00:30Z

src/main/java/mate/academy/carsharing/exception/CustomGlobalExceptionHandler.java

+import org.springframework.web.servlet.mvc.method.annotation.ResponseEntityExceptionHandler;
+
+@ControllerAdvice
+public class CustomGlobalExceptionHandler extends ResponseEntityExceptionHandler {


Let’s handle all your custom exception

liliia-ponomarenko · 2025-05-12T09:01:47Z

src/main/java/mate/academy/carsharing/model/Car.java

+
+    private int inventory;
+
+    @Column(name = "daily_fee", nullable = false)


Suggested change

@Column(name = "daily_fee", nullable = false)

@Column(nullable = false)

liliia-ponomarenko · 2025-05-12T09:04:10Z

src/main/java/mate/academy/carsharing/service/payment/PaymentServiceImpl.java

+        payment.setSessionId("none");
+        payment.setSessionUrl("http://none.none");


Why do you hardcode these values?

liliia-ponomarenko · 2025-05-12T09:05:54Z

src/main/java/mate/academy/carsharing/service/payment/PaymentServiceImpl.java

+        Payment payment = new Payment();
+        payment.setRental(rental);
+        payment.setType(type);
+        payment.setStatus(Payment.Status.PENDING);
+        payment.setAmountToPay(amountToPay);
+        payment.setSessionId("none");
+        payment.setSessionUrl("http://none.none");


Move this logic to the private method and simplify it. a good method should have less than 20 lines

liliia-ponomarenko · 2025-05-12T09:06:18Z

src/main/java/mate/academy/carsharing/service/payment/PaymentServiceImpl.java

+    }
+
+    @Override
+    @Transactional


move 'transaction above class

liliia-ponomarenko · 2025-05-12T09:06:57Z

src/main/java/mate/academy/carsharing/service/payment/stripe/StripePaymentServiceImpl.java

+        }
+    }
+
+    private Long calculateExpirationTime() {


move private method after public

Elena-Bruyako

Almost perfect)

Elena-Bruyako · 2025-05-14T19:07:24Z

src/main/java/mate/academy/carsharing/exception/CustomGlobalExceptionHandler.java

+
+    @ExceptionHandler(RegistrationException.class)
+    public ResponseEntity<Object> handleRegistrationException(RegistrationException ex) {
+        return buildResponse(HttpStatus.BAD_REQUEST, ex.getMessage());


Suggested change

return buildResponse(HttpStatus.BAD_REQUEST, ex.getMessage());

return buildResponse(HttpStatus.CONFLICT, ex.getMessage());

Elena-Bruyako · 2025-05-14T19:08:23Z

src/main/java/mate/academy/carsharing/repository/UserRepository.java

+import org.springframework.data.jpa.repository.JpaRepository;
+
+public interface UserRepository extends JpaRepository<User, Long> {
+    Boolean existsByEmail(String email);


Suggested change

Boolean existsByEmail(String email);

boolean existsByEmail(String email);

Elena-Bruyako · 2025-05-14T19:09:45Z

src/main/java/mate/academy/carsharing/service/user/UserServiceImpl.java

+    public UserResponseDto register(UserRegistrationRequestDto userRegistrationRequestDto)
+            throws RegistrationException {
+        if (userRepository.existsByEmail(userRegistrationRequestDto.getEmail())) {
+            throw new RegistrationException("Can't registration user "


Suggested change

throw new RegistrationException("Can't registration user "

throw new RegistrationException("Can't register user "

add car sharing project

d0a4492

Elena-Bruyako suggested changes May 6, 2025

View reviewed changes

trokhim03 and others added 11 commits May 8, 2025 11:07

Create README.md

203c5f7

Update README.md

15b56d1

Update README.md

a0c614f

Update README.md

c35bb5c

Update README.md

ee66c80

Update README.md

b592645

Update README.md

86fe890

Update README.md

86f44f2

Update README.md

9e0015c

Update README.md

9bfd142

fix after review

5abf1a9

liliia-ponomarenko suggested changes May 12, 2025

View reviewed changes

fix after review

e0c2013

Elena-Bruyako suggested changes May 14, 2025

View reviewed changes

fix after review

a42daff

sarakhmen approved these changes May 18, 2025

View reviewed changes

	@RequestBody UserRegistrationRequestDto userRegistrationRequestDto)
	@RequestBody @Valid UserRegistrationRequestDto userRegistrationRequestDto)

	public UserLoginResponseDto login(@RequestBody UserLoginRequestDto userLoginRequestDto) {
	public UserLoginResponseDto login(@RequestBody @Valid UserLoginRequestDto userLoginRequestDto) {

	payment = paymentRepository.save(payment);
	paymentRepository.save(payment);


		private int inventory;

		@Column(name = "daily_fee", nullable = false)

	@Column(name = "daily_fee", nullable = false)
	@Column(nullable = false)

		payment.setSessionId("none");
		payment.setSessionUrl("http://none.none");

	return buildResponse(HttpStatus.BAD_REQUEST, ex.getMessage());
	return buildResponse(HttpStatus.CONFLICT, ex.getMessage());

	Boolean existsByEmail(String email);
	boolean existsByEmail(String email);

	throw new RegistrationException("Can't registration user "
	throw new RegistrationException("Can't register user "

Comments

Conversation

trokhim03 commented May 5, 2025

Uh oh!

Elena-Bruyako left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liliia-ponomarenko left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Elena-Bruyako left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants