Pin rb_sys version when building for smoketests & release
#970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😎 Merged successfully - details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
+ Coverage 80.81% 81.09% +0.27%
==========================================
Files 66 66
Lines 14100 14100
==========================================
+ Hits 11395 11434 +39
+ Misses 2705 2666 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-trunk
requested review from
TylerJang27,
acatxnamedvirtue,
cmillar-trunk and
mb1206
as code owners
cmillar-trunk
approved these changes
Jan 6, 2026
| file: rspec-trunk-flaky-tests/rspec_trunk_flaky_tests.gemspec | ||
|
|
||
| # this is necessary because the cross-gem action doesn't support reading the Gemfile.lock from the subdirectory | ||
| # leading to a mismatch in the rb_sys version |
Collaborator
There was a problem hiding this comment.
Excellent comment explaining the arcana here, thank you.
rspec-trunk-flaky-tests/Gemfile
Outdated
|
|
||
| gem 'rake' | ||
| gem 'rake-compiler', '1.2.0' | ||
| gem 'rake-compiler' |
Collaborator
There was a problem hiding this comment.
Can we pin this to a more recent version instead of leaving it unbound?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smoketests started failing when a new version of
rb_syswas released yesterday https://github.com/oxidize-rb/rb-sys/releases/tag/v0.9.124, which utilizes Ruby 4The
cross-gemaction we use for building the rspec gem looks for aGemfile.lockfile at the root of the repo to parse the version ofrb_systo use. It does not respect the inputtedworking-directorywhen looking for theGemfile.lock(link). Since ourGemfile.lockis in therspec_trunk_flaky_testsdirectory,cross-gemdoesn't find it and defaults to latestrb_sys. That led to using Ruby 4 for the build and, since we're not yet compatible with Ruby 4, the build would fail.The fix I settled on was just copying the
Gemfile.lockto the repo root socross-gemcan find it and use the version ofrb_syswe expect. When I initially did that, we were onrb_sys0.9.103, which does not support Ruby 3.4, which is what we've been using to build :). So I also took this opportunity to upgrade ourrb_sysversion to 0.9.123. Keep in mind that this is the same version we've been using lately, sincecross-gemwould default to latest, so shouldn't be any surprises thereExample passing run with these changes: https://github.com/trunk-io/analytics-cli/actions/runs/20760863485