Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2026

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.

github-actions bot and others added 2 commits January 8, 2026 14:54
…nt to resend access granted email (#1988)

Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vercel
Copy link

vercel bot commented Jan 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
app (staging) Skipped Skipped Jan 8, 2026 10:02pm
portal (staging) Skipped Skipped Jan 8, 2026 10:02pm

@cursor
Copy link

cursor bot commented Jan 8, 2026

PR Summary

Trust Access improvements

  • New POST /v1/trust-access/admin/grants/:id/resend-access-email endpoint and OpenAPI docs; UI adds "Resend Access" action for active (non-expired) grants
  • Centralizes portal URL construction via helpers that prefer verified custom domain else friendlyUrl; auto-generates friendlyUrl slugs when enabling portal or missing
  • Refactors NDA flows to use new portal URL builders for portalUrl and access links; listGrants auto-marks past-due grants as expired
  • Tightens email template/types so AccessGrantedEmail always includes a required portalUrl and always renders the CTA button
  • Portal settings: removes editable friendly URL, keeps branding/contact email settings, ensures friendlyUrl is created when enabling; moves domain management into TrustPortalDomain section

Written by Cursor Bugbot for commit 0654f5d. This will update automatically on new commits. Configure here.

throw error;
}
}
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing fallback in friendly URL auto-heal function

Low Severity

The ensureFriendlyUrlIfEnabled function is missing a fallback when all 25 slug candidates are already taken. Unlike the equivalent ensureFriendlyUrl implementations in trust-access.service.ts and trust-portal-switch.ts which return organizationId as a fallback, this function silently returns without setting any friendlyUrl. When triggered, this causes the same 25 database queries to run on every page load, and the published portal remains without a friendlyUrl indefinitely.

🔬 Verification Test

Why verification test was not possible: This is a logic inconsistency bug that requires comparing three different implementations of similar functionality across the codebase. The bug manifests only when all 25 candidate slugs are already taken by other organizations, which requires a specific database state that cannot be easily unit tested without mocking Prisma and setting up complex test fixtures. The analysis was verified by reading the source code and comparing the three implementations - trust-access.service.ts line 118 and trust-portal-switch.ts line 77 both have return organizationId; as a fallback after the loop, while page.tsx has no equivalent fallback after its loop ends at line 197.

Fix in Cursor Fix in Web

…e resend button (#1991)

Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
…rants (#1992)

Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
@vercel vercel bot temporarily deployed to staging – portal January 8, 2026 22:02 Inactive
@vercel vercel bot temporarily deployed to staging – app January 8, 2026 22:02 Inactive
@Marfuen Marfuen merged commit 7393c6a into release Jan 8, 2026
13 of 14 checks passed
@claudfuen
Copy link
Contributor

🎉 This PR is included in version 1.75.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants