-
Notifications
You must be signed in to change notification settings - Fork 228
[comp] Production Deploy #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[comp] Production Deploy #1989
Conversation
…nt to resend access granted email (#1988) Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
PR SummaryTrust Access improvements
Written by Cursor Bugbot for commit 0654f5d. This will update automatically on new commits. Configure here. |
| throw error; | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing fallback in friendly URL auto-heal function
Low Severity
The ensureFriendlyUrlIfEnabled function is missing a fallback when all 25 slug candidates are already taken. Unlike the equivalent ensureFriendlyUrl implementations in trust-access.service.ts and trust-portal-switch.ts which return organizationId as a fallback, this function silently returns without setting any friendlyUrl. When triggered, this causes the same 25 database queries to run on every page load, and the published portal remains without a friendlyUrl indefinitely.
🔬 Verification Test
Why verification test was not possible: This is a logic inconsistency bug that requires comparing three different implementations of similar functionality across the codebase. The bug manifests only when all 25 candidate slugs are already taken by other organizations, which requires a specific database state that cannot be easily unit tested without mocking Prisma and setting up complex test fixtures. The analysis was verified by reading the source code and comparing the three implementations - trust-access.service.ts line 118 and trust-portal-switch.ts line 77 both have return organizationId; as a fallback after the loop, while page.tsx has no equivalent fallback after its loop ends at line 197.
…e resend button (#1991) Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
…rants (#1992) Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
|
🎉 This PR is included in version 1.75.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.