Added Pipfile and Bootstrap Progress Bar#90
Open
byt3bl33d3r wants to merge 4 commits intotryexceptpass:masterfrom
Open
Added Pipfile and Bootstrap Progress Bar#90byt3bl33d3r wants to merge 4 commits intotryexceptpass:masterfrom
byt3bl33d3r wants to merge 4 commits intotryexceptpass:masterfrom
Conversation
Author
|
Travis failed cause I used format string literals in the |
Owner
|
Hi thanks for the PR, I'd like to keep string literals, should probably change base support to 3.6+ ... It's just soooo much nicer. I promise I'll finish reviewing soon, very busy times both in and out of work these past few wks. |
tryexceptpass
requested changes
Feb 19, 2018
Owner
tryexceptpass
left a comment
There was a problem hiding this comment.
The only "required" package is autobahn, the rest are either dependencies, or packages required for the sample code:
*hypothesis is for testing, but i haven't written any tests with it yet, so we don't need it.
asynciois no longer needed since minimum python version is now 3.6.pytestis only required for testing.requestsandtweepyare only required for the samples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
First off insanely awesome project, I'm surprised this isn't more popular to be honest.
This commit adds a Pipfile to support installation using pipenv and a bootstrap progress bar (takes care of #48).
I'm not sure if this was the best way to implement it since I'm still getting familiar with the codebase, but hopefully it's a good starting point.
Cheers