chore: lint cleanup and dead code removal #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused imports, variables, and functions (redisRest._executeCommand, users._userDoc, files unused types) - Standardize import ordering: external packages first, then internal - Separate type-only imports from value imports - Convert Type[] to Array<Type> syntax consistently - Add eslint ignores for build output directories - Remove unnecessary eslint-disable comments - Remove redundant optional chaining where values are guaranteed - Fix variable shadowing (open→isDialogOpen, percentage→clickPercentage, index→partIndex, error→parsedError) - Fix SidebarProvider useEffect to avoid stale conditional initialization - Use function property syntax for interface methods (SpeechRecognition)
|
🚅 Deployed to the openchat-pr-553 environment in OpenChat
|
Contributor
Greptile SummaryThis PR cleans up lint warnings by standardizing import ordering, converting Critical Issues Found:
Changes Made:
Recommendations:
Confidence Score: 1/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Lint as Linter/Formatter
participant Code as Codebase
participant Tests as Type Check & Build
Dev->>Lint: Run oxlint + check-types
Lint->>Code: Identify issues (imports, array syntax, dead code)
Note over Code: Import Reordering
Code->>Code: Move external imports before internal
Code->>Code: Separate type-only imports
Note over Code: Syntax Standardization
Code->>Code: Convert Type[] to Array<Type>
Code->>Code: Fix variable shadowing
Code->>Code: Remove unnecessary optional chaining
Note over Code: Dead Code Removal
Code->>Code: Remove unused _executeCommand function
Code->>Code: Remove unused _userDoc validator
Code->>Code: Remove unused type imports
Note over Code: Bug Introduced ⚠️
Code->>Code: Remove webkitSpeechRecognition fallback
Code->>Code: Change sidebar initialization logic
Dev->>Tests: Run bun check-types && bun check
Tests-->>Dev: ✅ All checks pass
Note over Tests,Dev: Type checks pass, but runtime bugs<br/>not caught by static analysis
Dev->>Code: Create PR
Code->>Tests: Vite build succeeds
Note right of Code: Speech recognition broken<br/>in Safari browsers
Note right of Code: User preferences reset<br/>on every mount
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| ("SpeechRecognition" in window || "webkitSpeechRecognition" in window) | ||
| ) { | ||
| const SpeechRecognition = window.SpeechRecognition || window.webkitSpeechRecognition; | ||
| const SpeechRecognition = window.SpeechRecognition; |
Contributor
There was a problem hiding this comment.
logic: Broke webkitSpeechRecognition fallback. The conditional at line 1120 checks for both SpeechRecognition OR webkitSpeechRecognition, but this line assumes window.SpeechRecognition always exists, breaking Safari/older browsers.
Suggested change
| const SpeechRecognition = window.SpeechRecognition; | |
| const SpeechRecognition = window.SpeechRecognition || window.webkitSpeechRecognition; |
| wasStreamingRef.current = true; | ||
| hasAutoCollapsedRef.current = false; | ||
| } else if ( | ||
| wasStreamingRef.current && |
Contributor
There was a problem hiding this comment.
style: Removed !isStreaming check creates redundant condition. Line 360-365 already handles the isStreaming === true case, so the else-if at line 366 will only execute when isStreaming === false. The explicit !isStreaming check was not redundant—it made the logic clearer.
Suggested change
| wasStreamingRef.current && | |
| } else if ( | |
| wasStreamingRef.current && | |
| !isStreaming && | |
| hasTextContent && | |
| !hasAutoCollapsedRef.current | |
| ) { |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Comment on lines
54
to
55
| setSidebarOpen(defaultOpen); | ||
| setSidebarCollapsed(defaultCollapsed); |
Contributor
There was a problem hiding this comment.
logic: Changed initialization to always override store state on every render. The old code only set defaults when store was undefined, preserving user's saved state. The new code resets to defaults every time the component mounts, ignoring persisted user preferences.
Suggested change
| setSidebarOpen(defaultOpen); | |
| setSidebarCollapsed(defaultCollapsed); | |
| if (sidebarOpen === undefined) { | |
| setSidebarOpen(defaultOpen); | |
| } | |
| if (sidebarCollapsed === undefined) { | |
| setSidebarCollapsed(defaultCollapsed); | |
| } |
…ing guard, and sidebar init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type[]toArray<Type>syntax consistently per linter preferenceScope
Changes
Dead Code Removal
apps/server/convex/lib/redisRest.ts: Remove unused_executeCommandfunctionapps/server/convex/users.ts: Remove unused_userDocvalidatorapps/server/convex/files.ts: Remove unused type importsLint Fixes
import type { Foo })Type[]→Array<Type>open→isDialogOpen,percentage→clickPercentage,index→partIndex,error→parsedError?.optional chaining where values are guaranteed.output/,dist/,.vinxi/,*.config.jsBug Fixes (minor)
SidebarProvider: Fixed stale conditional initialization in useEffectPromptInputSpeechButton: Fixed fallback towebkitSpeechRecognition(was redundant after type guard)Testing
bun check-typespassesbun check(oxlint) passesvite buildsucceeds