Skip to content

fix(docker): align electric http port config #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leoisadev8 merged 1 commit into from
Oct 19, 2025
Merged

fix(docker): align electric http port config #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ services:
ELECTRIC_INSECURE: ${ELECTRIC_INSECURE:-false}
ELECTRIC_LOG_LEVEL: ${ELECTRIC_LOG_LEVEL:-info}
ELECTRIC_HTTP_PORT: ${ELECTRIC_HTTP_PORT:-3010}
ELECTRIC__HTTP__PORT: ${ELECTRIC_HTTP_PORT:-3010}
Copy link
Contributor

@greptile-apps greptile-apps bot Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: both ELECTRIC_HTTP_PORT and ELECTRIC__HTTP__PORT resolve to the same environment variable ${ELECTRIC_HTTP_PORT:-3010}. If a user overrides only ELECTRIC__HTTP__PORT in their .env, the legacy ELECTRIC_HTTP_PORT on line 47 will still default to 3010, potentially causing confusion.

Issue score: 2/5 – low risk in practice (most users set one variable), but the fallback chain isn't symmetric. Consider using separate variable names or documenting the precedence. Should ELECTRIC__HTTP__PORT read from a distinct env var (e.g., ${ELECTRIC__HTTP__PORT:-3010}) to allow independent override, or is the shared fallback intentional?

ELECTRIC__HTTP__HOST: ${ELECTRIC__HTTP__HOST:-0.0.0.0}
ELECTRIC__PG_PROXY__PORT: ${ELECTRIC__PG_PROXY__PORT:-5133}
ELECTRIC__PG_PROXY__HOST: ${ELECTRIC__PG_PROXY__HOST:-0.0.0.0}
Expand Down
140 changes: 0 additions & 140 deletions docs/deployment/railway.md
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@ ELECTRIC_GATEKEEPER_SECRET=replace-with-generated-secret
ELECTRIC_INSECURE=false
ELECTRIC_LOG_LEVEL=info
ELECTRIC_HTTP_PORT=3010
ELECTRIC__HTTP__PORT=3010
ELECTRIC__HTTP__HOST=0.0.0.0
ELECTRIC__PG_PROXY__PORT=5133
ELECTRIC__PG_PROXY__HOST=0.0.0.0
ELECTRIC_SERVICE_URL=http://openchat-electric:3000
ELECTRIC_SERVICE_URL=http://openchat-electric:3010

# --- API / Auth -------------------------------------------------------------
BETTER_AUTH_SECRET=replace-with-generated-secret
Expand Down