Layout improvements: Voltage bias and overlap resolution in LayoutPipelineSolver#26
Open
ManbirS07 wants to merge 3 commits intotscircuit:mainfrom
Open
Layout improvements: Voltage bias and overlap resolution in LayoutPipelineSolver#26ManbirS07 wants to merge 3 commits intotscircuit:mainfrom
ManbirS07 wants to merge 3 commits intotscircuit:mainfrom
Conversation
…dded a test for bias and overlap resolution
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fix: robustly resolve all chip overlaps in OverlapResolutionSolver Deep clone chip placements to avoid mutation Iteratively push overlapping chips apart until no overlaps remain If overlaps persist, aggressively scatter chips and rerun resolution Throw error if overlaps remain after max attempts
ManbirS07
commented
Sep 15, 2025
Author
ManbirS07
left a comment
ManbirS07
left a comment
There was a problem hiding this comment.
Tried to fix the overlapResolutionSolver file
Ran npm run format to format the code according to the requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #12
This PR improves schematic layout clarity and test reliability by:
Adding a VoltageBiasSolver that biases chips with positive voltage nets (VCC/VDD/V+) upward for conventional schematic readability.
Adding an OverlapResolutionSolver that detects and nudges apart overlapping chip placements using a bounding-box approach and chip sizes when available.
Integrating both phases into the LayoutPipelineSolver pipeline.
Adding targeted assertions to verify “no overlaps” and the presence of an upward bias for VCC/V* chips.
Key changes
VoltageBiasSolver.ts:
Scans netMap for positive-voltage nets and biases connected chips upward.
OverlapResolutionSolver:
Performs pairwise overlap checks and minimal nudging using chip sizes and ensures spacing via a minGap.
2 )Pipeline wiring
voltageBiasSolver added before packInnerPartitionsSolver.
overlapResolutionSolver added after partitionPackingSolver (operates on final layout).
onSolved hooks used only where data must be captured downstream.