feat: Specialized packing strategy for decoupling capacitors#28
feat: Specialized packing strategy for decoupling capacitors#28natinew77-creator wants to merge 12 commits intotscircuit:mainfrom
Conversation
|
@natinew77-creator is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
|
Ready for review! If there is any feedback, I am happy to address it. |
|
@natinew77-creator Join our discord for discussion and you can also drop your pr link in reviewme channel on the discord for fast reviews |
| console.log(`Group: ${group.decouplingCapGroupId}`) | ||
| console.log(` Main Chip: ${group.mainChipId}`) | ||
| console.log(` Caps: ${group.decouplingCapChipIds.join(", ")}`) |
seveibar
left a comment
There was a problem hiding this comment.
where is the evidence this works?
|
Hi @seveibar and @techmannih, I've updated the PR with the requested visual evidence and addressed the feedback regarding console logs and test assertions. |
seveibar
left a comment
There was a problem hiding this comment.
needs visual snapshot testing (i.e. svgs, as is our standard practice)

/claim #15
Implements a specialized packing strategy for decoupling capacitors to ensure neat, linear layouts.
Changes
packDecouplingCapsmethod toSingleInnerPartitionPackingSolver.Verification
Added
tests/DecouplingCapacitorPacking.test.tswhich verifies:The test output confirms the linear arrangement: