feat: merge same-net trace lines that are close together (Issue #34)#108
Open
giajoe24 wants to merge 3 commits intotscircuit:mainfrom
Open
feat: merge same-net trace lines that are close together (Issue #34)#108giajoe24 wants to merge 3 commits intotscircuit:mainfrom
giajoe24 wants to merge 3 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rushabhcodes
requested changes
Jan 17, 2026
rushabhcodes
left a comment
There was a problem hiding this comment.
You need to recreate an example of the problem, then show that you fixed the problem in a snapshot
Author
|
@rushabhcodes Here is the visual proof: Before (TraceCombineSolver input): After (TraceCombineSolver output): I also verified this with a reproduction test tests/reproduction_issue_34.test.ts which now passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Merge Close Parallel Trace Lines (Issue #34)
Description
This PR addresses Issue #34 by enhancing the TraceCombineSolver to identify and merge trace segments that are parallel and remain in very close proximity (within a 0.05 threshold), even if they are not strictly collinear or touching end-to-end.
Previously, TraceCombineSolver only handled collinear segments that were touching or overlapping. This improvement handles cases where traces might be slightly offset (e.g. due to floating point differences or grid alignment), consolidating them into a single clean trace aligned to their average center.
Changes
tests/reproduction_issue_34.test.tsto verify that close parallel traces are correctly merged into one.Verification
tests/reproduction_issue_34.test.tspasses (merges 2 close parallel traces into 1).Related Issue
Closes #34
/claim #34