feat: use collision-free base elbow paths directly#69
Open
RaghavArora14 wants to merge 4 commits intotscircuit:mainfrom
Open
feat: use collision-free base elbow paths directly#69RaghavArora14 wants to merge 4 commits intotscircuit:mainfrom
RaghavArora14 wants to merge 4 commits intotscircuit:mainfrom
Conversation
- Add early collision detection for base elbow paths in SchematicTraceSingleLineSolver2 - Skip complex pathfinding when no collisions exist with the default calculateElbow path - Improves performance and creates cleaner trace routing for collision-free cases - Maintains backward compatibility with existing pathfinding for collision cases - Add test to verify collision-free optimization works correctly Resolves tscircuit#68
|
@RaghavArora14 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
techmannih
reviewed
Oct 6, 2025
Member
techmannih
left a comment
techmannih
left a comment
There was a problem hiding this comment.
Could you please add snapshots
Author
hey is this correct ? |
- Added comprehensive test cases demonstrating bounty tscircuit#68 implementation - SVG snapshots show collision-free traces being used directly without pathfinding - Tests showcase long diagonal traces with obstacles that don't interfere - Visual proof that collision-free base elbow paths are used immediately This demonstrates the optimization where traces that don't cross any obstacles use the direct elbow path instead of going through the pathfinding algorithm.
- Applied biome formatting to test file - Ensures consistent code style across the project
Author
|
@seveibar @techmannih please tell me if anything else is required |
seveibar
requested changes
Oct 8, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
replicate the problem in the issue, then solve. Don't solve prior to replication
Author
|
Okay I'll replicate the issue and update the pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow straight-line traces when no collisions exist
Fixes: Allow drawing traces using the default
calculateElbowpath when there are no direct collisions, eliminating unnecessary complex routing.Changes
SchematicTraceSingleLineSolver2Testing
Impact
This will create cleaner, more direct traces in circuits like the boost converter example, where many connections can use straight-line routing without obstruction.
/fixes #68
/claim #68