Allow straight-line traces when no collisions exist#72
Open
Incharajayaram wants to merge 1 commit intotscircuit:mainfrom
Open
Allow straight-line traces when no collisions exist#72Incharajayaram wants to merge 1 commit intotscircuit:mainfrom
Incharajayaram wants to merge 1 commit intotscircuit:mainfrom
Conversation
Fixes: Allow drawing traces using the default calculateElbow path when there are no direct collisions, eliminating unnecessary complex routing. Changes - Added early collision detection for base elbow paths in SchematicTraceSingleLineSolver2 - When the default elbow path has no collisions, use it directly instead of complex pathfinding - Added 4-layer validation: collisions, path length, orthogonality, pin connections - Maintains full backward compatibility - existing pathfinding used when collisions exist - Improves performance for collision-free cases Testing - All existing tests pass (39/44 tests, 5 skipped as expected) - Added new test with visual snapshot verifying collision-free optimization works correctly - Verified no regressions in complex routing scenarios Impact This will create cleaner, more direct traces in circuits like the boost converter example, where many connections can use straight-line routing without obstruction. Fixes tscircuit#68
|
Someone is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Please review this PR @seveibar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: Allow drawing traces using the default calculateElbow path when there are no direct collisions, eliminating unnecessary complex routing.
Changes
Testing
Snapshot
Impact
This will create cleaner, more direct traces in circuits like the boost converter example, where many connections can use straight-line routing without obstruction.
/fixes #68
/claim #68