This repository was archived by the owner on Aug 26, 2024. It is now read-only.
Handle change in Rails 4.2.5.1 private method#48
Open
robdimarco wants to merge 2 commits intotscolari:masterfrom
Open
Handle change in Rails 4.2.5.1 private method#48robdimarco wants to merge 2 commits intotscolari:masterfrom
robdimarco wants to merge 2 commits intotscolari:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting in (rails/rails@0c5c32a) in Rails 4.2.5.1, the find_templates now takes a fifth argument. This causes a problem when the
chained_fallback_resolveris called to find the template.This pull requests adds an optional fifth argument to match the internal Rails method.
Without this patch, mobylette will not work with Rails 4.2.5.1