This repository was archived by the owner on Aug 26, 2024. It is now read-only.
Adjust the arguments of find_templates() for Rails 4.2.5.2, 4.1.14.2 and 3.2.22.2#51
Open
minamijoyo wants to merge 2 commits intotscolari:masterfrom
Open
Adjust the arguments of find_templates() for Rails 4.2.5.2, 4.1.14.2 and 3.2.22.2#51minamijoyo wants to merge 2 commits intotscolari:masterfrom
minamijoyo wants to merge 2 commits intotscolari:masterfrom
Conversation
…and 3.2.22.2 Rails 4.2.5.2, 4.1.14.2 and 3.2.22.2 have been released and these include a break change for find_templates(). This patch adjusts the arguments of find_templates(). refs: http://weblog.rubyonrails.org/2016/2/29/Rails-4-2-5-2-4-1-14-2-3-2-22-2-have-been-released/
minamijoyo
changed the title
| # using fallback if needed | ||
| # | ||
| def find_templates(name, prefix, partial, details) | ||
| def find_templates(name, prefix, partial, details, outside_app_allowed = false) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 4.2.5.2, 4.1.14.2 and 3.2.22.2 have been released and these include a break change for find_templates().
Rendering templates causes an error such as
ArgumentError: wrong number of arguments (5 for 4)This patch adjusts the arguments of find_templates().
refs: http://weblog.rubyonrails.org/2016/2/29/Rails-4-2-5-2-4-1-14-2-3-2-22-2-have-been-released/
see also:
rails/rails@v4.2.5.1...v4.2.5.2
rails/rails@v4.1.14.1...v4.1.14.2
rails/rails@v3.2.22.1...v3.2.22.2