Delete sprocket by sku#2
Open
P-Hill wants to merge 3 commits intotseaton:masterfrom
P-Hill:deleteSprocketBySku
Open
Delete sprocket by sku#2P-Hill wants to merge 3 commits intotseaton:masterfrom P-Hill:deleteSprocketBySku
P-Hill wants to merge 3 commits intotseaton:masterfrom
P-Hill:deleteSprocketBySku
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added deletedBySku to the SprocketRepository.
By itself, just adding the extra API executed without error and WITHOUT deleting anything.
:(
In addition I had to add @transactional to the SprocketRepository interface.
At first I hacked around with
@Modifying
@query("delete from Sprocket as m where m.sku = ?1")
To define explicitly what the delete should do. Once I got those two in place it complained of no transaction. Putting @transactional on the class worked with all 3 annotations, but it turns out @Modifying and the @query were not necessary. It all work just fine with just the API call and the @transactional.
Testing: I inserted extra Sprockets, displayed them, deleted one... displayed again. All appeared working.