fix(explore): add search_web and read_url to --repo and --project modes#225
fix(explore): add search_web and read_url to --repo and --project modes#225birdmanmandbir merged 2 commits intomainfrom
Conversation
PR Review — fix(explore): add search_web and read_url to --repo and --project modesSummaryThree specialized agents reviewed this PR. The changes are clean and targeted. No critical issues found. Important Issues[cmd/explore.go:118-121, 147-150] Bare error return — inconsistent with existing pattern The two new backend, err := resolveFetchBackend()
if err != nil {
return err // no context wrapping
}The existing call site in if err != nil {
return fmt.Errorf("resolve fetch backend: %w", err)
}Should be consistent — wrap with Suggestions[cmd/explore.go:127, 156] Duplicated tool list literal (DRY) The list Consider extracting a package-level var: var exploreCodespaceTools = []string{"bash", "read", "read_md", "glob", "grep", "search_web", "read_url"}[cmd/explore.go] Consider hoisting Since all four Positive Observations
VERDICT: LGTMThe error wrapping inconsistency is worth fixing but not blocking. Core logic is correct. |
Triage UpdateFixed
Deferred
|
Both exploreProject and exploreRepo now include search_web and read_url in their tool lists, enabling agents to search the web and read URLs while exploring a project or repository.
a0dc40c to
ae13603
Compare
Summary
search_webandread_urlto the tool list for bothexploreProject(--project) andexploreRepo(--repo)tools.NewDefuddleCLIBackend()with a properresolveFetchBackend()call in both functions (same pattern used by--urland--webmodes)Why
The
fetchBackendwas already being passed through but unused since neithersearch_webnorread_urlwas in thetoolNameslist. Agents exploring a project or repo can now check docs, APIs, or related resources on the web without switching to a separate--webor--urlinvocation.Test plan
make buildpassesmake testpasses (all tests green)