Refactoring minor parsing thing in the DataRecord and below#2
Merged
Conversation
tudborg
force-pushed
the
refactor/data-record
branch
from
ca50c0e to
6dd60b3
Compare
refactor(apl): remove opts from lower parse calls refactor(data-record-header): cleaning up header parse Squeezed ~5% extra performance out of the header as well.
tudborg
force-pushed
the
refactor/data-record
branch
from
6dd60b3 to
d1bebbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seem to have squeezed 5% extra performance out of the parser by accident.