Fixed moosh error downloading via git sources via git

[UncleDan]

https://docs.moodle.org/501/en/Git_for_Administrators#Obtaining_the_code_from_Git

[JedMeister]

Hey @UncleDan - thanks again for your contribution. 😁

FWIW the reason why we were using moosh was twofold:

• it can be a handy tool for installing and updating modules, as well as maintaining Moodle itself (we've had users ask for it)
• it will (or at least should) always download the latest stable version, so manually specifying the Moodle version to install is not required

As per your PR subject it sounds like moosh failed for you? Do you have any more info about the issue? Was it related to not using a GitHub token? (I suspect not). Or did it download/install ok and then fail to install? Or when pulling the latest stable moodle? Or something else?

Regardless, after having a quick look it appears that we weren't actually pulling a moosh release. Oops! We were just pulling from master... And it looks like the last moosh stable release was back in Feb and master has had lots of commits since then. So if the issue you hit was a failure in moosh itself - either installing or downloading moodle - then perhaps HEAD of master was buggy at the time? Perhaps ensuring that the latest stable moosh was installed instead might fix it? FWIW, you can get the latest moosh version like this:

gh_releases tmuras/moosh | tail -1

Currently that returns ``

You can clone the specific tag like this:

git clone --branch $(gh_releases tmuras/moosh | tail -1) --depth=1 https://github.com/tmuras/moosh.git

[JedMeister]

Oh and one more question. Is there a particular reason why you installed Moodle v4.x, rather than the newer v5.1.x release?:

https://download.moodle.org/releases/latest/
https://github.com/moodle/moodle/tree/MOODLE_501_STABLE

[UncleDan]

I thought passing to git was I good idea as it is documented in moodle guide to be the best for a production environment, reducing to a git pull the updates in the same major release and to a branch switch the major release bump.

[UncleDan]

I needed this version and something went wrong with 5: it could build but after installation everything was messed like no css or something and couldn't login

[JedMeister]

Thanks for the insight. I really appreciate the additional info. I'm currently working on v19.0 (specifically issues rebuilding updates of a couple of core components) so I won't have a look immediately, but I'll try to circle back ASAP.

[UncleDan]

@JedMeister trying to fix an installation from the official iso (could not install plugins) turns out that there are missing folders and wrong permissions. I integrated (quick and dirty) a script made to fix that. I will test also against 5.x to see if it is the same

[UncleDan]

Turned out that the problem with Moodle 5 was that the conf needed an update as the folder to point is "public" like in Laravel.
Now both the pull request are correctly Working.

[UncleDan]

Version superseded byhttps://github.com//pull/29