Unify error code in LibsqlError for local and remote#337
Merged
Conversation
d2e4109 to
ec2c466
Compare
41f0df4 to
717a512
Compare
sivukhin
approved these changes
Jan 7, 2026
We currently have divergence in what error code means in local and remote setups. Fix the consistency issue by making error code mean the basic one, which is what the SQL over HTTP protocol returns. However, add SQLite extended error codes to LibSqlError and populate that for the local setup. We'll add that for remote too, but that requires a SQL over HTTP protocol extension and server side change.
717a512 to
13e0490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have divergence in what error code means in local and remote setups. Fix the consistency issue by making error code mean the basic one, which is what the SQL over HTTP protocol returns.
However, add SQLite extended error codes to LibSqlError and populate that for the local setup. We'll add that for remote too, but that requires a SQL over HTTP protocol extension and server side change.