fix: Sync config changes to LAN clients on save

[turtton]

Summary

• 設定画面で保存時に ConfigSyncPayload を接続中の全プレイヤーへブロードキャストするように修正
• ConfigSyncPayload.broadcastToAll(server) を追加し、設定画面の save ハンドラから呼び出し

Closes #19

[Copilot]

Pull request overview

Adds a mechanism to re-sync server config to connected LAN clients when the host saves changes from the in-game config UI, addressing #19 (config was previously only synced on player join).

Changes:

• Add ConfigSyncPayload.broadcastToAll(server) to send the latest server config payload to all connected players.
• Invoke the broadcast from the config screen save handler when running an integrated (non-external) server.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/main/kotlin/net/turtton/connectedtank/network/ConfigSyncPayload.kt	Adds a helper to broadcast config sync payload to all connected players.
src/client/kotlin/net/turtton/connectedtank/config/CTConfigScreen.kt	Calls the new broadcast helper after saving server config in singleplayer/LAN host context.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

ConfigSyncPayload.broadcastToAll is invoked from the config screen save callback (client/UI thread), but it iterates server.playerManager.playerList and calls ServerPlayNetworking.send(...), which should be done on the integrated server thread to avoid race conditions with player list/network handler. Consider scheduling the broadcast via server.execute { ... } (or otherwise dispatching to the server thread) before calling broadcastToAll.

Suggested change

	client.server?.let { ConfigSyncPayload.broadcastToAll(it) }
	client.server?.let { server ->
	server.execute { ConfigSyncPayload.broadcastToAll(server) }
	}

[Copilot]

broadcastToAll(server) assumes it is safe to access server.playerManager.playerList and send packets immediately; however, this can be called from non-server threads (e.g., UI thread via the config screen). To prevent potential concurrent access issues, consider enforcing server-thread execution inside this method (dispatch to server.execute { ... }, or clearly document/guard the thread requirement).

Suggested change

	val payload = ConfigSyncPayload(CTServerConfig.instance.tankBucketCapacity)
	for (player in server.playerManager.playerList) {
	ServerPlayNetworking.send(player, payload)
	}
	val broadcastAction = {
	val payload = ConfigSyncPayload(CTServerConfig.instance.tankBucketCapacity)
	for (player in server.playerManager.playerList) {
	ServerPlayNetworking.send(player, payload)
	}
	}
	if (server.isOnThread) {
	broadcastAction()
	} else {
	server.execute {
	broadcastAction()
	}
	}