Conversation
板材とガラスの交互配置パターンでクラフト可能に。 板材はタグ指定のため全種類の木材に対応。 Closes #4
There was a problem hiding this comment.
Pull request overview
Adds a crafting recipe (planks + glass alternating) for the Connected Tank and integrates recipe generation into the existing Fabric datagen entrypoint so the recipe + unlock advancement JSON are generated automatically.
Changes:
- Adds a shaped crafting recipe for
connectedtank:connected_tank. - Adds the corresponding recipe-unlock advancement JSON.
- Extends
ConnectedTankDataGeneratorwith aRecipeProvider(Fabric datagen) to generate recipes.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/generated/data/connectedtank/recipe/connected_tank.json | New generated shaped crafting recipe for the Connected Tank. |
| src/main/generated/data/connectedtank/advancement/recipes/decorations/connected_tank.json | New generated recipe advancement to unlock the recipe. |
| src/client/kotlin/net/turtton/connectedtank/ConnectedTankDataGenerator.kt | Registers a RecipeProvider and defines the shaped recipe in datagen. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecipeProviderを追加し、レシピ JSON を自動生成Closes #4