Open
Conversation
efa479f to
76f454f
Compare
2fe561b to
6fe064d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves balancing in several ways:
TxSkeloption to defer validation failures occurring during balancing.As a consequence, the balancing succeeds even when running the script to assign execution units fails, and thus the balanced
TxSkelcan be traced.As a downside, this drastically decreases performances (as scripts are run several more times, even if we know they fail) and thus is only made available as an option, disabled by default.
TxSkeloption to cap the maximum amount of UTxOs that can be used for balancing purposes.This idea is that in the rare case where there are many candidate UTxOs, the algorithm would be too greedy, and thus some constraints need to be applied. This is now possible.
reachValueThe idea is that it now optimizes the solutions depending on how much overhead in terms of size, rather than by the minAda required for the extra payment. For instance, if a solution generates a very small extra payment, but with many additional inputs, and another generates a bigger extra output, but with fewers added inputs, then the latter will likely be picked.
The body is given back as a result of the balancing, and is directly used when submitting the transaction for validation in our main validation function.
This fixes an optimization bug in the fee computation
This improves the handling and generation of collaterals
Fixes #435
Fixes #494
Fixes #500
Fixes #503