Update build configuration to bazel 6#202
Merged
facundominguez merged 2 commits intomasterfrom Jul 13, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Updates the project’s build setup to use Bazel 6 and brings related tooling declarations up to matching versions, while migrating Haskell test targets to the new ghcopts attribute and adding timeouts.
- Bump Bazel in
shell.nixand pin a newer Nixpkgs commit innixpkgs.nix - Upgrade various
http_archiveand rule versions inWORKSPACE(rules_haskell, rules_nixpkgs, rules_go, gazelle) - Rename
compiler_flags→ghcoptsacross HaskellBUILD.bazelfiles, addtimeout = "short"to tests, and update.bazelrcfor Java 11
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| shell.nix | Upgrade bazel_4 → bazel_6 in development shell |
| nixpkgs.nix | Point to newer Nixpkgs commit and updated SHA256 |
| jvm/BUILD.bazel | Added timeout = "short" to haskell_test |
| jvm-types/src/test/haskell/BUILD.bazel | Replace compiler_flags with ghcopts |
| jvm-streaming/src/test/haskell/BUILD.bazel | Replace compiler_flags with ghcopts |
| jvm-streaming/benchmarks/BUILD.bazel | Replace compiler_flags with ghcopts |
| jvm-batching/src/test/haskell/BUILD.bazel | Replace compiler_flags with ghcopts |
| jvm-batching/benchmarks/BUILD.bazel | Replace compiler_flags with ghcopts |
| examples/hello/BUILD.bazel | Replace compiler_flags with ghcopts |
| examples/directory-server/BUILD.bazel | Replace compiler_flags with ghcopts |
| examples/classpath/BUILD.bazel | Replace compiler_flags with ghcopts |
| benchmarks/wizzardo-http/BUILD.bazel | Replace compiler_flags with ghcopts |
| WORKSPACE | Upgrade rule versions (rules_haskell, rules_nixpkgs, rules_go, bazel_gazelle) and reorganize Nixpkgs setup |
| BUILD.bazel (root) | Reordered load blocks and added test timeout attrs |
| .bazelrc | Added Java 11 flags and disabled strict Java deps |
Comments suppressed due to low confidence (1)
.bazelrc:9
- Disabling
experimental_strict_java_depscan have subtle effects on Java dependency resolution; please document the rationale for turning it off.
build --experimental_strict_java_deps=off
| # rule generated from jvm/jvm.cabal by gazelle_cabal | ||
| haskell_test( | ||
| name = "spec", | ||
| # keep |
There was a problem hiding this comment.
[nitpick] The comment # keep is ambiguous; consider clarifying its intent or removing it if it’s no longer needed.
facundominguez
commented
Jul 13, 2025
| build --java_language_version=11 | ||
| build --tool_java_language_version=11 | ||
| build --tool_java_runtime_version=11 | ||
| build --experimental_strict_java_deps=off |
Member
Author
There was a problem hiding this comment.
bazel complains otherwise that "//jvm-batching:jar" is missing from the direct dependencies of "//jvm-types:jar" even though the dependency is listed there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.