Added test to validate out-of-order popping in queue#114
Merged
diondokter merged 1 commit intotweedegolf:masterfrom Jan 8, 2026
Merged
Added test to validate out-of-order popping in queue#114diondokter merged 1 commit intotweedegolf:masterfrom
diondokter merged 1 commit intotweedegolf:masterfrom
Conversation
Member
|
Cool thanks! This is also already tested by the fuzzer. If something was wrong it would've been caught there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrolling through the test cases for
queue, I could not find a testcase usingiterwhich selectively pops some items, and leaves some of them intact. Strictly speaking this is not really queue-like behaviour but the current API allows for it. This test demonstrates that it functions as intented.