Fix NullPointerException when paramters key in URI contains semicolon#124
Open
clvs7-gh wants to merge 1 commit intotwofas:developfrom
Open
Fix NullPointerException when paramters key in URI contains semicolon#124clvs7-gh wants to merge 1 commit intotwofas:developfrom
clvs7-gh wants to merge 1 commit intotwofas:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When a semicolon is used in parameter key of the URI provided by the QR code, a
NullPointerExceptionoccurs in themapQueryParamsfunction, resulting in the messageThis QR Code does not work!being displayed and the QR code unable to be loaded. This fix addresses the issue.Effects of this fix
With this fix, services that generate URIs contains semicolon (
;), such as SimpleLogin with...&issuer=...in the URI, will also be registerable. (Such URI can be loaded in other apps like Microsoft Authenticator and Authy as well.)You can verify the fix using the following QR code generator:
https://stefansundin.github.io/2fa-qr/
Test URIs:
otpauth://totp/SAMPLE?secret=SAMPLE123&issuer=ExamplePrevious behavior before the fix
Displays "This QR Code does not work!" and cannot be registered.
Behavior after the fix
Registration is possible without displaying an error, similar to other apps.
Thank you.