Enhancement: Improve PasswordDialog validation with detailed error messages#201
Open
samuele-ruffino96 wants to merge 5 commits intotwofas:developfrom
Open
Conversation
added 5 commits
July 3, 2025 14:14
…rror messages - Add formatted length validation error with min/max values - Add confirm password mismatch error message - Add custom validation error with optional hint parameter - Use string interpolation for dynamic error messages - Maintain backward compatibility with existing usage patterns All backup screens now show more specific validation feedback to users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Description
This PR enhances the
PasswordDialogcomponent in the design system to provide more detailed and user-friendly validation error messages, addressing the UX improvements requested in #189. The changes improve the user experience across all backup-related screens by showing specific validation feedback.Changes Made
validationHintparameter for custom validation error messagesTechnical Details
PasswordDialog.ktincore/designsystemmoduleString.format()for dynamic error messagesImpact
This enhancement affects all screens that use
PasswordDialog:BackupExportScreen- Setting passwords for backup exportBackupScreen- Creating backup passwordsBackupImportScreen- Entering passwords for backup importBackupSettingsScreen- Managing backup password settingsUsers will now receive more specific feedback about password validation requirements, improving the overall user experience.